Skip to content

enable_workspace when bazel verison > 8 #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

enable_workspace when bazel verison > 8 #1387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions unused_deps/unused_deps.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,37 @@ javac_params = aspect(
`
)

/**
* Parses `bazel version` output and returns the version string.
* Example output:
* Build label: 8.2.1
* Build target: bazel-out/darwin-fastbuild/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
* Build time: Wed Jan 27
*/
func bazelMajorVersion() (int, error) {
out, err := cmdWithStderr(*buildTool, "version").Output()
if err != nil {
return 0, err
}
lines := strings.Split(string(out), "\n")
for _, line := range lines {
if strings.HasPrefix(line, "Build label: ") {
version := strings.TrimPrefix(line, "Build label: ")
parts := strings.Split(version, ".")
if len(parts) < 1 {
return 0, fmt.Errorf("could not parse version from 'bazel version' output: %s", version)
}
var major int
_, err := fmt.Sscanf(parts[0], "%d", &major)
if err != nil {
return 0, fmt.Errorf("could not parse major version from 'bazel version' output: %s", version)
}
return major, nil
}
}
return 0, errors.New("could not find version in 'bazel version' output")
}

Comment on lines +86 to +109
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also use this to conditionally, create a MODULE.bazel file and then use override_module instead of repository; I guess both approaches could work and that would probably needed eventually for Bazel 9+ when WORKSPACE is gone.

func stringList(name, help string) func() []string {
f := flag.String(name, "", help)
return func() []string {
Expand Down Expand Up @@ -381,6 +412,9 @@ func main() {
buildCmd = append(buildCmd, "--output_groups=+unused_deps_outputs")
buildCmd = append(buildCmd, "--override_repository=unused_deps="+aspectDir)
buildCmd = append(buildCmd, "--aspects=@@unused_deps//:unused_deps.bzl%javac_params")
if version, err := bazelMajorVersion(); err == nil && version >= 8 {
buildCmd = append(buildCmd, "--enable_workspace=true")
}
buildCmd = append(buildCmd, buildOptions()...)

blazeArgs := append(buildCmd, targetPatterns...)
Expand Down