Skip to content

Expose additional rpmbuild arguments to pkg_rpm #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Draft

Expose additional rpmbuild arguments to pkg_rpm #702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/rpm_pfg.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,6 +630,8 @@ def _pkg_rpm_impl(ctx):
#### Remaining setup

additional_rpmbuild_args = []
if ctx.attr.rpmbuild_args:
additional_rpmbuild_args.extend(ctx.attr.rpmbuild_args)
if ctx.attr.binary_payload_compression:
additional_rpmbuild_args.extend([
"--define",
Expand Down Expand Up @@ -1001,6 +1003,9 @@ pkg_rpm = rule(
"rpmbuild_path": attr.string(
doc = """Path to a `rpmbuild` binary. Deprecated in favor of the rpmbuild toolchain""",
),
"rpmbuild_args": attr.string_list(
doc = """Additional arguments to pass to rpmbuild (such as `--rpmrc=path/to/rpmrc`)""",
),
# Implicit dependencies.
"_make_rpm": attr.label(
default = Label("//pkg:make_rpm"),
Expand Down