Include transitive out directories when running rustc #3542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only the out directories of build scripts that are direct dependencies were included when running rustc. This caused errors when linking when a transitive dependency's build script builds an archive into the out directory and adds a link argument to it via `cargo::rustc-link-lib`. Now all out directories of transitive dependencies are collected into a depset and included as dependencies in the rustc compile action.
|
I have no idea why the test is segfaulting on OSX. I've ran this locally on an arm64 mac and it works fine. I'm tempted to switch this to a build_test instead and not run it, because whether the test runs is inconsequential to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only the out directories of build scripts that are direct dependencies were included when running rustc. This caused errors when linking when a transitive dependency's build script builds an archive into the out directory and adds a link argument to it via
cargo::rustc-link-lib.Now all out directories of transitive dependencies are collected into a depset and included as dependencies in the rustc compile action.
For some reason this test segfaults when running with
bazel coverage. It runs locally fine, so I'm not sure what the issue is here. I've just disabled the test because I can't see how it'd be relevant to my change.