Skip to content

fix: document upload qa III #2725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trslater merged 3 commits into from
Jan 12, 2026
Merged

fix: document upload qa III #2725

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52314ce
fix: cleared the selectable parcels array to fix document upload fiel…
PaulGreywal Jan 10, 2026
bbcab89
chore: fix lint spacing
PaulGreywal Jan 10, 2026
9772bf4
chore: typo
PaulGreywal Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions alcs-frontend/src/app/shared/document-upload-dialog/document-upload-dialog.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ export class DocumentUploadDialogComponent implements OnInit, OnDestroy {

async prepareCertificateOfTitleUpload(uuid?: string) {
this.source.setValue(DOCUMENT_SOURCE.APPLICANT);

// If fixedParcel is provided, use it and don't require validation
if (this.data.fixedParcel) {
this.parcelId.setValue(this.data.fixedParcel.uuid);
Expand All @@ -287,7 +287,7 @@ export class DocumentUploadDialogComponent implements OnInit, OnDestroy {
this.parcelId.updateValueAndValidity();
return;
}

// We have parcels to select from now, so we will require it here
this.parcelId.setValidators([Validators.required]);
this.parcelId.updateValueAndValidity();
Expand Down Expand Up @@ -332,6 +332,7 @@ export class DocumentUploadDialogComponent implements OnInit, OnDestroy {

async onDocTypeSelected($event?: DocumentTypeDto) {
if (!$event) {
this.selectableParcels = [];
return;
}

Expand All @@ -353,6 +354,7 @@ export class DocumentUploadDialogComponent implements OnInit, OnDestroy {
this.parcelId.setValue(null);
this.parcelId.setValidators([]);
this.parcelId.updateValueAndValidity();
this.selectableParcels = [];
}

if ($event.code === DOCUMENT_TYPE.CORPORATE_SUMMARY) {
Expand Down