fix(optimizer): simplify redundant intersections in allOf schemas#672
Open
privatenumber wants to merge 2 commits intobcherny:masterfrom
Open
fix(optimizer): simplify redundant intersections in allOf schemas#672privatenumber wants to merge 2 commits intobcherny:masterfrom
privatenumber wants to merge 2 commits intobcherny:masterfrom
Conversation
privatenumber
commented
Oct 8, 2025
| oneOf?: SchemaArray;␊ | ||
| not?: CoreSchemaMetaSchema;␊ | ||
| [k: string]: unknown;␊ | ||
| } & (␊ |
Author
There was a problem hiding this comment.
Looks like it was able to de-duplicate this too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a JSON Schema uses
allOfwith$refthat overlap, the generated TypeScript contains redundant intersections and duplicate properties.Example from the
tsconfig.jsonschema:This happens when:
$ref’d multiple times$refwraps the base in anallOfwith extra constraintsBefore
Changes
Optimizer (
optimizer.ts)A & (A | null)→A | null(A & (A | null))and(A | null) & AA & B & A & B → A & BGenerator (
generator.ts)Setexport typedeclarationsAfter