feat(gas-price): add ActivityTracker for dynamic caching based network activity #782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…work activity - Implemented the ActivityTracker class to monitor network activity per chain and optimize RPC call frequency. - Added methods to record activity, retrieve activity levels, and recommend caching intervals based on usage patterns. - Created unit tests for ActivityTracker to ensure correct functionality of activity recording and interval recommendations. - Integrated ActivityTracker into GasPriceService and CacheFeesJob to dynamically adjust caching intervals based on recorded activity. This enhancement aims to reduce unnecessary RPC calls and improve resource utilization by adapting caching strategies to actual network usage.
TheDivic
added
the
⬆️ Enhancement
vr16x
reviewed
May 1, 2025
Comment on lines
+24
to
+25
| log.info(`Decrypted config: ${JSON.stringify(decryptedConfig)}`); | ||
|
|
Contributor
There was a problem hiding this comment.
Why do we need to log the decrypted config ? This will expose the encrypted data to logs
vr16x
requested changes
May 1, 2025
Contributor
vr16x
left a comment
vr16x
left a comment
There was a problem hiding this comment.
All looks good for me. Except logging the decrypted data to logs
Contributor
Author
Nice catch, I was having some problems with that so I added a debug statement and forgot to delete it |
Contributor
|
@TheDivic Are you pushing the change for this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Context
Type of change
Why are we doing this?
This enhancement aims to reduce unnecessary RPC calls and improve resource utilization by adapting caching strategies to actual network usage.
What did we do?
How Has This Been Tested?