Skip to content

Conversation

@fichiokaku
Copy link
Contributor

📖 Context

Type of change

  • Non-breaking change (backwards compatible)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Why are we doing this?

  • Customer X complained that PVG was too high on Y network so we discovered that ...
  • The service was crashing on production because of ...
  • Person A from team B asked me to do this so they can ...

Related issues:

  • link to issue / ticket

What did we do?

  • We changed the PVG formula to use ...
  • Added a try/catch clause to prevent crashes when ...

How Has This Been Tested?

  • Tested this manually by sending a user op on the Y network and ...
  • Added unit tests that check if ...

👀 How do I review this?

  • Check the parameters in file ... and compare them to ...
  • To test this you first need to checkout this branch and run the following command ...

@fichiokaku fichiokaku requested a review from vr16x November 24, 2025 13:11
@fichiokaku fichiokaku merged commit 60850b3 into master Nov 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants