WIP: Patch tests #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and generator logic
…methods in `patch_test_generator.rb`
…s and removing redundant logic
…liminating redundancy in `patch_test_generator.rb`
…h_test` and update `patch_test_generator` to use `create_fhirpath_patch_data` instead of `create_patch_data`
…test` and comment out `fhir_operation` implementation
…esource` and update `create_patch_data` to include `patchset_data` logic
…Parameter`, and update `patch_test_generator` to simplify `create_patch_data` logic using decorators
… deprecate `fhir_patch` logic
… update `Content-Type` to `application/fhir+json`.
… support multiple patch options (XML, JSON, FHIRPath). Streamline path conversion and patch execution logic.
…eusing extracted variables for `parameters_resource` and `patchset`
…in `patch_test_generator`
…arily disable XML patch test with a placeholder
…_generator` to streamline test generation
…tch_json_test` and streamline `fhir_fhirpath_patch` execution
…ch` for streamlined patch execution
…integrate it into `fhir_fhirpath_patch` for enhanced FHIR client functionality
…and `tags` options for enhanced customization
… decorator integration
…t patch options to JSON, and update tests with placeholders for unimplemented functionality
… `patch.rb.erb`, update `create_patch_data` logic, and include `GenericUtils` in `PatchTestGenerator`
…g resource ID handling, and improving payload retrieval
…erform_json_patch_test` for improved encapsulation
…mproved patchset validation
…ndency to improve utility access
… validation and enhance debug logging
…ion, improve attempt logic, and enhance debug logs
…ameter, ensuring thorough resource version validation
…ic, and streamline resource version validation
…ersion validation
…ersion validation, and enhance attempt logic
…loads, and add support for 204 status code
…on workflows - Integrate `jsonpath` gem for advanced filtering capabilities. - Implement `filter_set` to enable JSONPath-based filtering logic in validation tests. - Update resource filtering to support complex conditions using JSONPath expressions. - Modify Gemfile and Gemfile.lock to include `jsonpath` dependency.
… inferno_suite_generator
…ng in suite generator - Allow `extra_imports` to be defined and processed dynamically. - Add `rewrite_igs` configuration for overriding IG identifiers. - Extend getter methods in config to support the new settings.
- Use `positive?` for `filter_set` length checks to enhance readability. - Standardize and clean up version validation logic across PATCH and UPDATE tests. - Improve block formatting in `create_interaction_exists?` for consistency. - Remove redundant `else nil` clause in update test generator. - Ensure `jsonpath` gem dependency is correctly formatted in Gemfile.
- Address `nil` handling issue in `filtered_resources` assignment. - Simplify conditional logic for `filter_set` in resource selection.
- Ensure consistent handling of empty `filter_set` across modules. - Simplify conditional logic and improve readability. - Fix assignment issue for filtered resources.
- Introduce `BasicTestHelpers` module for shared test utilities. - Refactor `filterset_on_resource` to use consistent naming with `?` suffix. - Replace `demo_resources` accessors with `existing_demo_resources` for clarity. - Simplify teardown candidate and resource ID registration with helper methods. - Use `default_patch_body_list` for cleaner patch body initialization. - Add private helper methods to streamline code readability and reuse.
…rivate methods for improved readability and reuse.
… error handling for unsupported operations
… test data handling - Extract test data generation methods (`xml_test_data`, `json_test_data`, `fhirpath_xml_data`, `fhirpath_json_data`) for better organization. - Simplify `current_test_data` logic using a mapping structure. - Add helper methods for `transaction_bundles` and `bundle_entries` to streamline resource handling. - Improve `patch_entry` and `parameters_resource` consistency with modular methods.
- Extract `initiate_empty_result`, `initiate_empty_arrays_for_resource_types`, and `update_result` as helper methods. - Simplify result initialization and resource type handling logic. - Improve clarity and reduce duplication in patch body processing.
… handling and normalization logic - Add new test modules to `.rubocop.yml` exclusions. - Replace `each_with_index` with manual index handling in `patch_test` and `update_test` to simplify iteration.
…ng in `inferno_suite_generator` - Add `extra_imports`, `rewrite_igs`, and `filter_set` methods to extend functionality. - Update module definitions to reflect new capabilities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.