Merged
Conversation
michplunkett
commented
Mar 3, 2025
michplunkett
commented
Mar 3, 2025
michplunkett
commented
Mar 3, 2025
Comment on lines
+26
to
+29
| # TODO: Create dev, test, and prod versions of settings that do not have | ||
| # TODO: to be passed in as a parameter | ||
| if settings is None: | ||
| settings = get_settings() |
Collaborator
Author
There was a problem hiding this comment.
The next step will be to have the Settings object setup automatically depending on the ENV variable.
michplunkett
commented
Mar 7, 2025
| """ | ||
| if not hasattr(self, '_permissions'): | ||
| self._permissions = {} | ||
| if not self._permissions: |
Collaborator
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
ok, I see it is defined in the readme.
TODO for me is standardize those definitions in the readme
msramalho
reviewed
Mar 9, 2025
msramalho
reviewed
Mar 9, 2025
michplunkett
commented
Mar 10, 2025
msramalho
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do?
This formats and lints the web directory of the application and adds ruff to the default pre-commit pipeline.