implementing default metadata omission/user metadata selection #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjgaughan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @msramalho - I hope all is well. This is the current implementation that I have for the relevant metadata feature (#143).
I'm a bit unsure whether I'm correctly passing through the user arguments to the enricher. Besides that issue, I have implemented basic functionality and testing. I think a little more work is necessary before this feature gets deployed, specifically around user support depending on what the default functionality is. I can add documentation if we do want to change default behavior + support the selection of specified subgroups of metadata.
Happy to take notes/make edits on implementation if you have different thoughts. Thank you!