Skip to content

Added value not false check when assigning root for package #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2018
Merged

Added value not false check when assigning root for package #3

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62602d5
Added value not false check when assigning root for package
ptMuta Aug 3, 2018
2c3b14e
A more elegant fix as suggested by @benjamn
ptMuta Aug 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tuple.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export { tuple };
// object, there's no reliable way to get the global object across all JS
// environments without using the `Function` constructor, so instead we
// use the global `Array` constructor as a shared namespace.
const root = globalKey in Array
const root = globalKey in Array && Array[globalKey]
? Array[globalKey]
: def(Array, globalKey, new UniversalWeakMap, false);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this could just be

const root = Array[globalKey] ||
  def(Array, globalKey, new UniversalWeakMap, false);

since the value of the property is always truthy once we've defined it?


Expand Down