Add the ability to specify custom repos#20
Open
StephenAmar wants to merge 1 commit intobenley:masterfrom
StephenAmar:custom_repos
Open
Add the ability to specify custom repos#20StephenAmar wants to merge 1 commit intobenley:masterfrom StephenAmar:custom_repos
StephenAmar wants to merge 1 commit intobenley:masterfrom
StephenAmar:custom_repos
Conversation
Owner
|
Thank you for the pull request! I've been on vacation and didn't notice this PR until just now. Is pex_repos something that should be set separately for each pex_binary/library/test rule, or would it make more sense to have it be configurable repo-wide in the WORKSPACE file, like how the maven_server repository rule works? I have been hoping to evolve the pex rules toward letting Bazel take care of the downloading (and caching!) rather than having pex do it each time a pex_binary rule gets built. I haven't yet come up with a good way of accomplishing that, though... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.