Absinthe Subscriptions #1
Conversation
| @@ -0,0 +1,97 @@ | |||
| defmodule Absinthe.Phoenix.Channel do | |||
There was a problem hiding this comment.
Note, this file will be extracted to the Absinthe.Phoenix project here shortly.
|
|
||
| chan.on("new:msg", msg => { | ||
| $messages.append(this.messageTemplate(msg)) | ||
| chan.on("subscription:data", msg => { |
There was a problem hiding this comment.
Hey @benwilson512
I'm trying to adapt this example project for testing subscription-support on apollo-phoenix-websocket but I was wondering why on this line, we listen for subscription:data topic, looking at the absinthe subscription branch looks like its currently hardcoded so I guess it's a temporary thing you had just for getting the example work. I was thinking perhaps the response from thesubscription resolution should to the client the topic to listen for new data coming from that subscription.
So I suppose the subscriptions branch on absinthe is still missing something to be completed ?
There was a problem hiding this comment.
Today I got the example chat application working with apollo subscriptions, the only change worth of mentioning is this one so that updates get sent (and most importantly, the client subscribes to) different events per gql subscription, instead of always getting them on a single subscription:data event.
No description provided.