Conversation
…ead and totalAssetsWei for config pools
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the existing staking pools frontend with a Vue 3 + Vite SPA and adds supporting configuration, utilities, and automated tests to support single-pool and discovery modes (plus optional “Nosy mode” scanning).
Changes:
- Migrates the frontend from React/JSX to Vue 3 (Vite + Vue plugin) with updated runtime config handling and theming.
- Adds unit tests (Vitest) and E2E tests (Playwright) plus enhanced wallet/contract mocking helpers.
- Updates installer helper to generate a Vue-compatible
public/config.draft.jsonfor single-pool deployments.
Reviewed changes
Copilot reviewed 97 out of 109 changed files in this pull request and generated 19 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/staking-pools/install-helpers/generate-frontend-config.sh | Updates generated config output path/schema for the new Vue frontend. |
| apps/staking-pools/frontend/vite.config.js | Switches Vite plugin to Vue and updates dev server settings. |
| apps/staking-pools/frontend/vitest.config.js | Adds Vitest config for unit tests. |
| apps/staking-pools/frontend/src/utils/shareholderFromEvents.js | Adds shareholder registry computation for Nosy-mode cached events. |
| apps/staking-pools/frontend/tests/unit/shareholderFromEvents.spec.js | Adds unit tests for shareholder registry computation. |
| apps/staking-pools/frontend/tests/unit/errors.spec.js | Adds a placeholder unit test for errors module. |
| apps/staking-pools/frontend/tests/helpers/pool-scenarios.js | Adds reusable E2E scenario/mocks based on live-ish pool data. |
| apps/staking-pools/frontend/tests/helpers/mock-wallet-enhanced.js | Adds enhanced mock wallet transport for deterministic E2E. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add gap-fill logic to scan between maxCachedBlock and chain tip on resume - Fix missing factoryAddr parameter in runTipScan causing TypeError - Add debug logging for cached events and ranges
Replace janky .includes('exited') patterns with structured helpers
- Remove unused imports and variables across test helpers - Replace redundant null checks (v == null || v === undefined) with idiomatic v == null - Fix BigInt precision loss in pool-scenarios (use formatEther) - Add real assertion to errors.spec.js unit test - Set vite server.open to false to avoid unwanted browser launches - Use validator status helpers instead of string comparisons
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 99 out of 111 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apps/staking-pools/frontend/tests/helpers/mock-wallet-enhanced.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Camembera <camembear@berachain.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Camembera <camembear@berachain.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDWR check out https://bepolia-pools.vercel.app/
Stack
Configuration and Branding
config.deploy.bepolia.json,config.deploy.mainnet.json, etcpublic/branding/for demos and theming.User-Facing Features
WalletConnect.vueDocs and Deployment
.vercelignoreand config for Vite SPA.Testing
26 e2e tests with playwright and a mock wallet