Skip to content

Conversation

@rsmithlal
Copy link
Member

  • Add CommunityInvitationNotifier for handling notifications via ActionCable and email.
  • Create CommunityInvitationPolicy to manage permissions for creating, destroying, and resending invitations.
  • Enhance CommunityPolicy to allow access based on invitation status and tokens.
  • Develop views for invitation review, including actions to accept or decline invitations.
  • Introduce invitations panel for inviting members via email or existing users.
  • Create invitations table to display current invitations with status and actions.
  • Update routes to include nested resources for community invitations.
  • Add factories and specs for CommunityInvitation model and its functionalities.
  • Implement tests for invitation review and token access scenarios.
  • Add internationalization support for invitation-related strings in multiple languages.

Summary

Describe the change and the motivation.

Checklist

  • Tests added/updated and passing (bin/ci).
  • Lint and security checks (rubocop, brakeman, bundler-audit).
  • Documentation updated under docs/ describing new/changed functionality.
  • Mermaid diagrams (docs/*.mmd) updated to reflect changes.
  • Rendered PNGs regenerated with bin/render_diagrams and committed.
  • For DB changes, included any needed backfills/dedupes and noted risks.

Screenshots / Diagrams

If applicable, include screenshots or link to updated diagrams.

Notes

Anything reviewers should be aware of (migration order, flags, feature toggles).

- Add CommunityInvitationNotifier for handling notifications via ActionCable and email.
- Create CommunityInvitationPolicy to manage permissions for creating, destroying, and resending invitations.
- Enhance CommunityPolicy to allow access based on invitation status and tokens.
- Develop views for invitation review, including actions to accept or decline invitations.
- Introduce invitations panel for inviting members via email or existing users.
- Create invitations table to display current invitations with status and actions.
- Update routes to include nested resources for community invitations.
- Add factories and specs for CommunityInvitation model and its functionalities.
- Implement tests for invitation review and token access scenarios.
- Add internationalization support for invitation-related strings in multiple languages.
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +158 to +161
partial: 'better_together/communities/invitation_row',
collection: @community.invitations.order(:status, :created_at))
], status:
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Complete turbo-stream render arguments

In Communities::InvitationsController#render_success_turbo_stream, the render call ends with status: without a value. Ruby treats a keyword without an argument as a syntax error, so this controller cannot even load, blocking any community invitation create/resend responses (HTML/Turbo/JSON). The keyword should supply the status parameter (e.g., status: status) to avoid failing at boot time.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants