#[entities] should error when put on a enum variant

[mirsella]

hello !

Bevy version

bevy 0.16.0

If your bug is rendering-related, copy the adapter info that appears when you run Bevy.

What you did

#[derive(Component)]
pub enum TroopState {
    Idle,
    #[entities] // should error
    Run(Option<Target>),
    #[entities] // should error
    Attack(Target),
}
#[derive(Component)]
pub struct Target {
    #[entities]
    pub entity: Entity,
}

Target is not mapped, this is a footgun, without any warning

What went wrong

the #[entities] should be on the associated type like so Run(#[entities] Option<Target>)
maybe the derive macro can error when the annotation is on the enum variant instead of actual type ?

[Bleachfuel]

this is really part of a bigger problem, since the relationship attribute behaves differently, and we would probably also want a different behaviour for when deriving MapEntities, instead of via the component derive.