-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Fix naming overlap between bevy_scene and bevy_scene_2 #23606
Copy link
Copy link
Open
Labels
A-ScenesComposing and serializing ECS objectsComposing and serializing ECS objectsD-StraightforwardSimple bug fixes and API improvements, docs, test and examplesSimple bug fixes and API improvements, docs, test and examplesS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!X-BlessedHas a large architectural impact or tradeoffs, but the design has been endorsed by decision makersHas a large architectural impact or tradeoffs, but the design has been endorsed by decision makers
Milestone
Description
We cannot immediately remove bevy_scene, as the ECS world serialization pattern is not covered by bevy_scene_2 currently. However, we should give the nice names to the new BSN work.
Steps:
- Rename
bevy_scenetobevy_ecs_serialization. - Rename
bevy_scene2tobevy_scene. - Rename
bevy_ecs_serialization::Sceneand friends to resolve naming overlap. Alternatively, remove it from the prelude. - Make sure that the new
bevy_sceneprelude is re-exported inbevy::prelude.
Each of these should be a distinct PR for reviewability and merge conflicts.
Step 2 is going to break a lot of open PRs, but such is life.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-ScenesComposing and serializing ECS objectsComposing and serializing ECS objectsD-StraightforwardSimple bug fixes and API improvements, docs, test and examplesSimple bug fixes and API improvements, docs, test and examplesS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!X-BlessedHas a large architectural impact or tradeoffs, but the design has been endorsed by decision makersHas a large architectural impact or tradeoffs, but the design has been endorsed by decision makers