Skip to content

Add null check before deleting models in CleanEmails.php #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Add null check before deleting models in CleanEmails.php #138

wants to merge 1 commit into from

Conversation

anilkumarthakur60
Copy link

No description provided.

@mechelon mechelon self-requested a review July 18, 2025 15:04
@mechelon mechelon changed the base branch from master to dev July 25, 2025 09:52
mechelon
mechelon requested changes Jul 25, 2025
View reviewed changes
Copy link
Member

@mechelon mechelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate why you implemented this check and can you provide a test for it?

Also, please resolve the merge conflict to work with your proposed change (keep changes for PR #137)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mechelon mechelon mechelon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anilkumarthakur60 @mechelon