(#2567) fix htmx renderer for checkpoint selection#2568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the handling and population of options for the
resume_from_checkpointfield in the form, ensuring that available checkpoints in the specified output directory are accurately listed and selectable. It also improves the robustness of the front-end logic for detecting the output directory input and adds a test to verify the new behavior.Backend improvements to checkpoint option handling:
FieldServiceto dynamically populate theresume_from_checkpointfield's options with available checkpoints from the specified output directory, ensuring deduplication and inclusion of the current value if not already present.CheckpointManagerto support checkpoint discovery in the backend service.Frontend robustness:
form_field.htmlto reliably detect the output directory input field by checking multiple possible selectors, improving compatibility with different form layouts. [1] [2]Testing:
test_field_service_resume_from_checkpoint.py) to verify that local checkpoints are correctly included in the options for theresume_from_checkpointfield.