fix: DeepSpeed device_placement ValueError#2570
Merged
bghira merged 1 commit intobghira:mainfrom Feb 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
accelerator.prepare()fails with DeepSpeed due to customdevice_placementparameter.Problem
When using DeepSpeed ZeRO Stage 2/3, training fails with:
Root Cause
Accelerate raises this error when
device_placementis passed with DeepSpeed:accelerate/accelerator.py:1458-1461SimpleTuner passes
device_placementunconditionally:trainer.py:3628-3632Solution
Skip
device_placementparameter when using DeepSpeed, as DeepSpeed handles device placement internally.Test