feat(api): set scheduling InitiatedByUserId on batch and constraint publishes - #242
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Populates
InitiatedByUserIdonSchedulePeriodRequestandHandleConstraintChangeRequestusing the current JWT user, so asynchronous engine results can be correlated with the triggering operator.Implementation details
ScheduleController:User.GetUserId()on batch enqueue.UserConstraintService/ActivityConstraintService:IHttpContextAccessor+ safe resolver for initiator guid.IHttpContextAccessormock with nullHttpContextwhere existing tests do not model a request.Testing
dotnet test tests/Chronos.Tests.MainApi/Chronos.Tests.MainApi.csprojinitiatedByUserIdin dev.Risk / rollout
Low. Additive fields on messages; null initiator if unauthenticated or no HTTP context (should not occur for these authorized controller/service entry points in normal operation).
Rollback
Revert PR; messages revert to
initiatedByUserId: null; notifications won’t target users until re-deployed.Files in this PR (only)
Chronos.Service/src/Chronos.MainApi/Schedule/Controllers/ScheduleController.csChronos.Service/src/Chronos.MainApi/Schedule/Services/UserConstraintService.csChronos.Service/src/Chronos.MainApi/Schedule/Services/ActivityConstraintService.csChronos.Service/tests/Chronos.Tests.MainApi/Services/Schedule/ActivityConstraintServiceTests.csChronos.Service/tests/Chronos.Tests.MainApi/Services/Schedule/UserConstraintServiceTests.cs