Skip to content

MPS implementation#11

Open
khurramscience wants to merge 2 commits intobiaslab:mainfrom
khurramscience:main
Open

MPS implementation#11
khurramscience wants to merge 2 commits intobiaslab:mainfrom
khurramscience:main

Conversation

@khurramscience
Copy link

No description provided.

@khurramscience
Copy link
Author

MPS implementation showed great improvements

@wouterwln
Copy link
Member

Hey @khurramscience, thanks for the interest in the paper and for the deep dive on the big tensor scaling issue.

The Tensor Train/MPS approach is a solid idea (and one I was unaware of). Using the Rényi entropy trick to bypass the Shannon summation is a clever move for this kind of state/observation space.

A few quick things on the PR:

  • This repo is a specific artifact for the paper's experiments, so I want to keep the core code as-is to ensure reproducibility for people reading the original work, and to keep the code to implement the exact idea from the paper.
  • The PR now adds a .zip file, I can't really review or merge a .zip file for security and version control reasons.
  • If you want to put the code in a separate public repo (or want me to host one on my personal/biaslab github), send me the link. I’d be happy to check it out there (and maybe I can contribute), and if that approach helps scale the next phase of this project, I'd be more than happy to credit you for the idea/implementation.

Cheers,
Wouter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments