[ENH] BEP045: "Peripheral" physiology (raw data)#2267
Draft
smoia wants to merge 22 commits intobids-standard:masterfrom
Draft
[ENH] BEP045: "Peripheral" physiology (raw data)#2267smoia wants to merge 22 commits intobids-standard:masterfrom
smoia wants to merge 22 commits intobids-standard:masterfrom
Conversation
I'm not sure if a corresponding change should be made to modalities.yaml, I'm having trouble finding where the latter table is used by the compiler macros.
Incorporate physio BEP section 4 to physiological-recordings.md
Add physio as a datatype
Some checks on formatting (particularly for how I entered the allowable values) might be necessary here, I also added some comments on the BEP document to flag potential issues or changes we could make going forward.
effigies
reviewed
Dec 1, 2025
| description: | | ||
| Amplifier settings during data acquisition (e.g. gain, sampling filters, bandwidth, etc.) | ||
| Strings MAY be represented in the format Setting:Value (e.g. Gain:10) | ||
| type: array of strings |
Collaborator
There was a problem hiding this comment.
Suggested change
| type: array of strings | |
| type: array | |
| items: | |
| type: string |
| from participant to recording device. A pseudonym can also be used to | ||
| prevent the equipment from being identifiable, so long as each | ||
| pseudonym is unique within the dataset. | ||
| type: string or array of strings |
Collaborator
There was a problem hiding this comment.
Suggested change
| type: string or array of strings | |
| anyOf: | |
| - type: string | |
| - type: array | |
| items: | |
| type: string |
| the sensor, connecting cables, and amplifiers. If more than one manufacturer | ||
| applies, list the manufacturer for each piece of hardware, in order | ||
| of attachment from participant to recording device. | ||
| type: string or array of strings |
Collaborator
There was a problem hiding this comment.
Suggested change
| type: string or array of strings | |
| anyOf: | |
| - type: string | |
| - type: array | |
| items: | |
| type: string |
| produced the measurements upstream of the recording device, including | ||
| the sensor, connecting cables, and amplifiers. Equipment should be listed | ||
| in order of attachment, from participant to recording device. | ||
| type: string or array of strings |
Collaborator
There was a problem hiding this comment.
Suggested change
| type: string or array of strings | |
| anyOf: | |
| - type: string | |
| - type: array | |
| items: | |
| type: string |
neuromechanist
added
Proposed BEP
Removed example file structure for physiological recordings.
Add MeasureType descriptions section to documentation
Removed unnecessary code blocks and clarified recommendations for recording physiological data.
Added descriptions for various MeasureTypes related to physiological recordings.
Updates to src/modality-specific-files/physiological-recordings.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This BEP proposes an expansion of the raw physiological data section of the standard.
The main development is happening in https://github.com/physiopy/bids-specification-physio
To see the rule of engagements, see the discussion board.
To leave comments, engage with the physiopy repository (specifically, with its PR #32) rather than with this PR.
However, we're not really ready for reviews or comments yet, we are opening a draft just to have the HTML and schema json preview. We will communicate ASAP when we are ready for public engagement.