Skip to content

fix: sha tus#566

Merged
ypriverol merged 3 commits intomainfrom
dev
Jan 19, 2026
Merged

fix: sha tus#566
ypriverol merged 3 commits intomainfrom
dev

Conversation

@selvaebi
Copy link
Collaborator

@selvaebi selvaebi commented Jan 19, 2026

Pull Request

Description

Brief description of the changes made in this PR.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring
  • Test addition/update
  • Updates to the dependencies has been done.

Summary by CodeRabbit

  • Chores
    • Updated the Subresource Integrity (SRI) hash for a third‑party script to ensure integrity checks remain valid.
    • Added an archive extraction utility to the container image so archives can be extracted during runtime.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 19, 2026

📝 Walkthrough

Walkthrough

Updated the Subresource Integrity (SRI) hash for the tus-js-client script tag in the HTML template, and added the unar package to the project's Dockerfile system dependencies. No application logic or exported/public declarations were changed.

Changes

Cohort / File(s) Summary
HTML Template Update
pmultiqc_service/templates/index.html
Replaced the SRI hash value for the tus-js-client script tag (script URL unchanged).
Container Build
pmultiqc_service/Dockerfile
Added unar to the apt-get install list to include RAR extraction support in the build image.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

Review effort 3/5

Poem

🐰 I nibbled through a hash so slight,
Popped unar in the image, snug and light,
A tiny tweak, no logic to confide,
Just safer loads and archives opened wide. 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix: sha tus' is vague and does not clearly convey the specific changes made in the pull request. Use a more descriptive title that specifically identifies what was fixed (e.g., 'fix: update tus-js-client SRI hash' or 'fix: add unar dependency and update SRI hash').
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ypriverol ypriverol self-requested a review January 19, 2026 11:17
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
pmultiqc_service/Dockerfile (1)

7-22: Fix failing build: unrar isn't available in default Debian repos.

python:3.10-slim uses Debian's main repository only. The unrar package is in non-free, so this build will fail with "unrar has no installation candidate".

Choose one:

  1. Enable non-free repos if you need the official unrar (best for RAR5 support):

    RUN echo "deb http://deb.debian.org/debian bookworm main non-free" >> /etc/apt/sources.list.d/non-free.sources.list

    Then install unrar as-is.

  2. Use unar (recommended alternative in main, supports modern RAR):
    Replace unrar with unar.

  3. Use p7zip-rar if your workflow already uses 7zip:
    Replace unrar with p7zip-rar and invoke via 7z x.

Avoid unrar-free—it only supports RAR1–3 versions and will likely fail on modern files.

@ypriverol ypriverol merged commit 30b8ef2 into main Jan 19, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants