-
Notifications
You must be signed in to change notification settings - Fork 29
Minor updates and merge from dev branch #703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a7ce8c3
minor updates
yueqixuan 0521bef
update
yueqixuan 289885f
Merge pull request #702 from yueqixuan/dev
ypriverol 83eda90
feat(quantms): read quantms.io parquet when mzTab is absent
ypriverol f912619
fix
yueqixuan fdeb2b5
Merge pull request #705 from yueqixuan/feat/quantms-qpx-source-ladder
ypriverol f1722f4
fix(quantms): address review findings on the qpx source ladder
ypriverol e80528e
chore: ignore the vscode AI rules file
ypriverol 2c62e94
update
yueqixuan b1c388d
Merge pull request #707 from yueqixuan/feat/quantms-qpx-source-ladder
ypriverol 4ce4f31
Merge pull request #704 from bigbio/feat/quantms-qpx-source-ladder
ypriverol File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Delegated mode ignores an available external design file.
_derive_design_onlyreads onlyrun.parquet/sample.parquet. In delegated mode,self.enable_exporself.enable_sdrfcan already be true becauseget_data(Lines 142-160) discoveredpmultiqc/exp_designor an SDRF file. Two consequences follow:_derive_design_onlyreturns early andself.file_dfstays empty. All QPX sample-level plots are then skipped, although a parseable design file exists.Consider parsing the external design without rendering when it is present, and using parquet only as the fallback.
♻️ Sketch of a design-source preference in delegated mode
if not self.draw_experimental_design: # A host module owns this section. Still derive the design -- the # sample-level plots below need the run -> sample mapping -- but do not # render it a second time. - self._derive_design_only() + # An external design file stays authoritative over the parquet-derived one. + self._derive_design_only(prefer_exp_design=self.enable_exp or self.enable_sdrf)🤖 Prompt for AI Agents