Conversation
The PRIDE copy of qpx_example.zip returns 404, so the test_qpx job fails at the download step. This is specific to that one file, not a PRIDE outage -- the other assets this workflow pulls from the same host still serve fine (LFQ_PXD007683.zip returns 200, 408 MB), so the remaining 24 PRIDE URLs are left alone. Points at the GitHub attachment copy instead. Verified it is the same file: identical size (831,756 bytes) and identical sha256 (02c2a9bd314d81ebc50d0b24c98fe9aec526c8ce8d032fc9f38fe3251f435154), same 16 entries including results/multiqc_config.yml which the job passes to --config. Ran the job's three steps locally against main with a clean Python 3.12 install: download, unzip, and the multiqc invocation. Exit 0, no tracebacks, no swallowed failures, 24 sections, no duplicate anchors, 2.6 MB report. Adds -O so the output name does not depend on the URL's trailing path.
Same 404 as the CI job: docs/config.json drives the example-report generation and both qpx entries (qpx and qpx_disable_hoverinfo) pointed at the PRIDE copy of qpx_example.zip, which no longer exists. The README download link pointed there too. All three now use the GitHub attachment, verified identical by sha256 (02c2a9bd...f435154, 831,756 bytes). Only the qpx URLs change. The other 44 PRIDE URLs in config.json are fine -- PRIDE itself is up, it is this one file that is missing. Also makes the FTP attempt conditional in update_examples.py. download_file rewrites https:// to ftp:// and tries FTP three times with backoff before falling back to HTTPS; against a host that never served FTP that is three connection timeouts plus ~6s of sleep, twice, for no possible gain. It now tries FTP only for hosts named ftp.*, so PRIDE keeps its retries and HTTPS-only hosts go straight to the path that works. Verified with the real downloader against the updated config: HTTPS on the first attempt, 831,756 bytes, 0.7s.
ci: fetch the qpx example from a working URL
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe QPX example archive now uses a GitHub-hosted URL in CI and documentation. Example updates skip FTP retries for non-FTP hosts and use HTTPS fallback directly. ChangesQPX dataset source handling
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to This PR updates the qpx example URL in CI and documentation. No actionable merge-blocking risk remains, so it is merge-ready after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
2 participants
Pull Request
Description
Brief description of the changes made in this PR.
Type of Change
Summary by CodeRabbit
Bug Fixes
Documentation