Skip to content

Conversation

@Tainan404
Copy link
Member

@Tainan404 Tainan404 commented Apr 10, 2025

What does this PR do?

  • Adds the set camera focus by userId or streamId on client

How to test

  • Join a meeting with three users
  • Share webcam in all of them
  • Open one user devtools
  • Run this command on console
const ev = new CustomEvent('SET_CAMERA_FOCUS_COMMAND', {
      detail: {
        focus: true,
        webcamSelector: [ { userId: '<userId>'}],
      },
    });
window.dispatchEvent(ev);

More

Closely related to bigbluebutton/bigbluebutton#22931

@welcome
Copy link

welcome bot commented Apr 10, 2025

Thank you for this contribution! Could you please confirm if you already sent in the signed Contributor License Agreement? See https://docs.bigbluebutton.org/support/faq.html#why-do-i-need-to-sign-a-contributor-license-agreement-to-contribute-source-code Thanks in advance!

Copy link
Collaborator

@GuiLeme GuiLeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any particular reason why we should allow the developer to pass a list of ObjectTo, instead of only one?
I thought that, perhaps in the future, we would support being able to set focus to multiple webcams at the same time, is that it? (I made the same comment in the other PR).

Comment on lines +75 to +76
}
,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
,
},

Adjusting typescipt error.

);
},
/**
* Sets the in focus camera for a specific user.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Sets the in focus camera for a specific user.
* Sets the focused camera for a specific user.

/**
* Sets the in focus camera for a specific user.
*
* @param setSelfViewDisableCommandArguments: object with a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @param setSelfViewDisableCommandArguments: object with a
* @param setCameraFocusCommandArguments: object with a

Parameter name is slightly off.

* Sets the in focus camera for a specific user.
*
* @param setSelfViewDisableCommandArguments: object with a
* boolean that tells whether to enable or disable the camera focus for specific user.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* boolean that tells whether to enable or disable the camera focus for specific user.
* object that tells whether to enable or disable the camera focus for specific user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants