-
Notifications
You must be signed in to change notification settings - Fork 12
Feat(plugin): Add set camera focus as ui-command #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v0.0.x
Are you sure you want to change the base?
Conversation
|
Thank you for this contribution! Could you please confirm if you already sent in the signed Contributor License Agreement? See https://docs.bigbluebutton.org/support/faq.html#why-do-i-need-to-sign-a-contributor-license-agreement-to-contribute-source-code Thanks in advance! |
GuiLeme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any particular reason why we should allow the developer to pass a list of ObjectTo, instead of only one?
I thought that, perhaps in the future, we would support being able to set focus to multiple webcams at the same time, is that it? (I made the same comment in the other PR).
| } | ||
| , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| } | |
| , | |
| }, |
Adjusting typescipt error.
| ); | ||
| }, | ||
| /** | ||
| * Sets the in focus camera for a specific user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * Sets the in focus camera for a specific user. | |
| * Sets the focused camera for a specific user. |
| /** | ||
| * Sets the in focus camera for a specific user. | ||
| * | ||
| * @param setSelfViewDisableCommandArguments: object with a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * @param setSelfViewDisableCommandArguments: object with a | |
| * @param setCameraFocusCommandArguments: object with a |
Parameter name is slightly off.
| * Sets the in focus camera for a specific user. | ||
| * | ||
| * @param setSelfViewDisableCommandArguments: object with a | ||
| * boolean that tells whether to enable or disable the camera focus for specific user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * boolean that tells whether to enable or disable the camera focus for specific user. | |
| * object that tells whether to enable or disable the camera focus for specific user. |
What does this PR do?
How to test
More
Closely related to bigbluebutton/bigbluebutton#22931