Skip to content

Conversation

GuiLeme
Copy link
Collaborator

@GuiLeme GuiLeme commented Aug 15, 2025

What does this PR do?

This PR separates the previous pingSoundEnabled which controlled the browser notification as well into the 2 settings:

  • pingSoundEnabled: Same name, different feature - It controls only the ping sound;
  • browserNotificationEnabled: Now, this flag controls the browser notification;

One other important change is: the ping sound comes enabled by default while the browser notification doesn't.

Motivation

For the browser notification to appear, it needs to ask for permission from the browser, which is not the ideal for every user - it can cause the person to question their privacy while using BBB. Despite that inconvenience, it's good to maintain the ping sound.

A good solution, then, is to separate the flag to enable the ping sound from the flag to enable the browser notification.

More

This PR depends on the recent refactor from #68.

Copy link
Member

@ramonlsouza ramonlsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if nothing is added to BBB's settings.yml file (default settings), an error is displayed and the ping sound is not played

no-audio-error

@GuiLeme GuiLeme requested a review from ramonlsouza August 21, 2025 20:42
@GuiLeme
Copy link
Collaborator Author

GuiLeme commented Aug 21, 2025

@ramonlsouza I fixed that issue and found another one: Sometimes, if the current user is selected, the ping sound plays multiple times - I fixed that too in the same commit.

@antobinary antobinary merged commit 81af8fd into bigbluebutton:v0.0.x Aug 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants