Skip to content

Conversation

@leeBigCommerce
Copy link
Contributor

What?

Describe what changes you are making. e.g. Adds X prop in the Box component.

Why?

Please provide the reason(s) why you are making this change? Please no one-liners like, It was missing.; expand upon the reason like, Adds X prop because it was missing in the Box component. Documentation notes this prop exists, but it actually wasn't implemented.

Screenshots/Screen Recordings

This is a component library so we love visually looking at changes! If this applies to your pull request, show us your hard work in action.

Testing/Proof

Explain how you tested your new feature or bugfix. Please refrain from one-liners like, Added tests.; expand upon how you tested your changes like, Added local tests to the new component and ensured test coverage was met. Manually tested on [email protected]..

@leeBigCommerce leeBigCommerce added the do not merge Don't merge this PR! label Nov 14, 2024
@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2024

⚠️ No Changeset found

Latest commit: 45a2648

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Don't merge this PR!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant