feat(storefront): STRF-9258 Stencil Pull: Provide an activate option#739
feat(storefront): STRF-9258 Stencil Pull: Provide an activate option#739jairo-bc wants to merge 1 commit intobigcommerce:masterfrom
Conversation
f592db5 to
66ce9e1
Compare
mattolson
left a comment
There was a problem hiding this comment.
Code looks good, but not sure about the naming of the option. If I understand correctly, the new option overrides the variation to use when fetching the configuration to merge. So it doesn't really "activate" a variation, it merges the given variation's configuration (as opposed to the default variation).
Thinking about this functionality more, I'm not sure it's working in the best possible way. When we merge these configurations, we put it into the top-level "settings" object. However, the variations still exist in the config file, and when this is re-uploaded, those variations will be layered on top of the base settings object. So if you think about the full experience of stencil pull + edits + stencil push against the Cornerstone Bold variations for example, we would pull the existing Bold configuration, merge it into the default settings object, but because the Bold variation still exists in config.json, when re-uploaded, we wouldn't see those settings, we would see whatever is still leftover in the Bold variation (a separate object in config.json).
|
@mattolson Maybe the name is not the best. I'm using the same as we currently have for Regarding functional approach. And I'm adding activate option for |
What?
Refactored Stencil Pull command to have ability write unit tests.
Added activate option for Stencil Pull
Tickets / Documentation