fix(cli): auto-migrate on fts:rebuild + optimize (2.2.1)#60
Merged
Conversation
The 2.2.0 upgrade recipe said to run `vendor/bin/imanager fts:rebuild` after `composer update`, but the command opened a raw PDO without running pending migrations. The rebuild fired against the pre-2.2.0 schema (fields.searchable=0 everywhere) and silently produced an empty FTS body for every item. Caught while bumping Scriptor's composer.lock — fixed before reaching the Hetzner demo. DatabaseFactory::migrateIfNeeded() is the new shared primitive: announces each pending migration via the command's output, then applies. Called from FtsRebuildCommand and OptimizeCommand. Diagnostic commands (dump, repair, schema:status) are deliberately left alone — they must report on the on-disk state, not a post-migration state. CHANGELOG 2.2.0 upgrade block carries a visible 2.2.1 correction note so anyone reading the published Keep-a-Changelog entry sees the issue, rather than the entry being silently edited. VERSION 2.2.0 -> 2.2.1; ReleaseConsistencyTest enforces match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2.2.0 upgrade recipe said to run
vendor/bin/imanager fts:rebuildaftercomposer update, but the command opened a raw PDO without running pending migrations. The rebuild fired against the pre-2.2.0 schema (fields.searchable=0 everywhere) and silently produced an empty FTS body for every item. Caught while bumping Scriptor's composer.lock — fixed before reaching the Hetzner demo.DatabaseFactory::migrateIfNeeded() is the new shared primitive: announces each pending migration via the command's output, then applies. Called from FtsRebuildCommand and OptimizeCommand. Diagnostic commands (dump, repair, schema:status) are deliberately left alone — they must report on the on-disk state, not a post-migration state.
CHANGELOG 2.2.0 upgrade block carries a visible 2.2.1 correction note so anyone reading the published Keep-a-Changelog entry sees the issue, rather than the entry being silently edited.
VERSION 2.2.0 -> 2.2.1; ReleaseConsistencyTest enforces match.