Make the ifconfig output more portable#225
Open
climent wants to merge 3 commits intobinhex:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I worked over the weekend trying to make your image creation process work with alpine instead of archlinux, but it was failing. The iptables output had a different entry for the docker network and was rejecting my connections. It all boiled down to a different ifconfig output.
Probably a better fix would be to move the ifconfig output to "ip ad show dev ${docker_interface}" instead of trying to parse the output of a tool that has not been consistently ported to different linux flavours.