This repository was archived by the owner on Nov 9, 2023. It is now read-only.
Filter mapping file issue#2062
Open
wdwvt1 wants to merge 2 commits into
Open
Conversation
Changes the code for the qiime.filter.filter_mapping_file to work as intended. Pep8 has been checked for the lines modified, other failures in those files are unrelated to this commit.
This commit updates the script filter_samples_from_otu_table.py so that it has a script usage test for the --output_mapping_fp option as well as modifying how that option works.
|
Build results will soon be (or already are) available at: http://ci.qiime.org/job/qiime-github-pr/1663/ |
Contributor
|
retest this please |
|
Build results will soon be (or already are) available at: http://ci.qiime.org/job/qiime-github-pr/1719/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does 3 things:
qiime.filter.filter_mapping_filebehaves to match the documentation.--output_mapping_fpinfilter_samples_from_otu_table.py: now writes a subsetted mapping file that retains all the metadata columns of the original passed mapping file regardless of their uniqueness status.filter_samples_from_otu_table.pyfor the--output_mapping_fpI believe change 2 is good because: we are not exposing the control of whether or not unique metadata columns are written in the script (we don't mention it in the documentation either) and so it is very startling to see that data disappear when you use the
--output_mapping_fpoption. In addition, its easy to remove columns in e.g. excel, whereas its annoying to have to add columns back in if you have output a reduced mapping file. Also, its useful to retain non-unique and totally unique columns with a reduced mapping file if you are e.g. trying to work with a new dataset and see what the values for a particular set of samples are.