feature/finegrain-region-read#195
Merged
Merged
Conversation
BrianWhitneyAI
requested review from
SeanDuHare,
aswallace,
kmitcham,
pgarrison and
toloudis
kmitcham
approved these changes
Jun 24, 2026
| # direct reader sub-region read | ||
| if ( | ||
| dimension_order_out is not None | ||
| and kwargs |
Contributor
There was a problem hiding this comment.
so the presence of any extra kwargs could trigger this? I assume we want some specific ones in this case.
Contributor
Author
There was a problem hiding this comment.
This is true will fix!
Contributor
Author
There was a problem hiding this comment.
Actually the only accepted kwargs are slice per the function definition so I think its fine to assert directly here. I added a comment about it though
SeanDuHare
approved these changes
Jun 24, 2026
| """ | ||
| # If no out orientation, simply return current data as dask array | ||
|
|
||
| # direct reader sub-region read |
Contributor
There was a problem hiding this comment.
Can you expand this comment - these boolean checks are a bit wonky to read
Contributor
Author
There was a problem hiding this comment.
yeah will do. Essentially we are inverting the lower checks to say, if its a slice and not weird dims like mosaic then use the direct path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a subsequent release to the update in bioio-base==3.4.0 with more fine-grained region reading. This PR bumps the version and provides a path to the update