[FIX] Network Explorer: Clear selection on new network and when removing network

[janezd]

Issue

Fixes #111.

Includes

• Code changes
• Tests

[codecov-io]

Codecov Report

Merging #184 (b4517a9) into master (247b3d8) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
+ Coverage   75.23%   75.26%   +0.03%     
==========================================
  Files          21       21              
  Lines        2790     2794       +4     
==========================================
+ Hits         2099     2103       +4     
  Misses        691      691              

Impacted Files	Coverage Δ
orangecontrib/network/widgets/OWNxExplorer.py	77.97% <100.00%> (+0.19%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 247b3d8...b4517a9. Read the comment docs.

[VesnaT]

The Network Explorer widget does not work for me.
There seems to be a problem with _fr_layout.

[janezd]

I just tried with a fresh environment. In it

• I installed orange3 from conda-forge
• install cython
• ran python setup.py develop in orange, base widget and canvas
• ran pip install -e . in network add (I don't know why I used pip here... out of habit?)
  ... and everything works.

I don't know how to replicate and debug this. And I don't know what could be wrong, actually.

BTW, how does it doesn't work?

[VesnaT]

I guess, the cleared selection should result on the selected_data output as well, but it does not:
Connect Network File -> Network Explorer -> Data Table (with Selected Data) and select some points. After removing the Network File, selected data retains in Data Table. The same selected data is there after re-connecting Network File to Network Explorer with some other network.

This seems strange, since sending the selected data should be handled in parent widget.

[VesnaT]

I prefer testing a widgets behavior to its properties. This test does not assure no selection on the output.
Adding
self.assertIsNone(self.get_output(self.widget.Outputs.selected_data))
results in a failed test.

[janezd]

This seems strange, since sending the selected data should be handled in parent widget.

handleNewSignals does not call the inherited method because the derived widget is too different. (We have had similar problems in other widgets, too.)

The overriden version did not call unconditional_commit.

[VesnaT]

When opening a saved workflow with selected instances, the selection is cleared. Is that intentional?

[janezd]

Here's another one: select some variable for Color. Then remove data. Variable remains selected.

I discovered this when fixing the pending selection. This widget does not properly reset itself because it does not call the inherited methods for this. The reason is, as I recall, that its signals are a bit more complicated. @VesnaT, when we can work together again, we should study this problem together.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.07%. Comparing base (ec534c9) to head (4ebf7c5).
⚠️ Report is 123 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
+ Coverage   74.55%   75.07%   +0.52%     
==========================================
  Files          21       21              
  Lines        2916     2921       +5     
==========================================
+ Hits         2174     2193      +19     
+ Misses        742      728      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.