Skip to content

Conversation

@janezd
Copy link
Contributor

@janezd janezd commented Dec 19, 2025

Issue

Fixes #7174.

Description of changes
  • Add a test that every widget has a string with keywords.
    The test tries to not cause false positives: not having keywords does not result in crashes but only causes problems for translators, which can complain about this.

    • The test is opt-in: add-ons can -- but don't have to -- register for the test.
    • The widget is tested only if it is final class and contains a name.
    • Despite this, mock widgets have to define keywords if they define a name.

This PR also adds keywords where necessary.

Includes
  • Code changes
  • Tests

@janezd janezd force-pushed the require-keywords branch 6 times, most recently from 9ec2130 to aeb44eb Compare December 20, 2025 10:11
@codecov
Copy link

codecov bot commented Dec 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.03%. Comparing base (9e35194) to head (4cf0bd5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7218   +/-   ##
=======================================
  Coverage   89.03%   89.03%           
=======================================
  Files         335      335           
  Lines       74243    74253   +10     
=======================================
+ Hits        66100    66112   +12     
+ Misses       8143     8141    -2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@janezd janezd marked this pull request as ready for review December 20, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Every widget should have keywords

1 participant