Skip to content

Conversation

@janezd
Copy link
Contributor

@janezd janezd commented Dec 30, 2025

Issue

Fixes #5499, assuming that weird behaviour is caused by context settings. (Which it almost certainly is.)

Description of changes

As per title, I replaced context settings with schema-only (non-context) settings. The only remaining context setting is the variable.

It gets even better. Rules were already an "internal context setting" with the variable as a context. That is, if the user sets the rules for one variable, switches to another, sets some rules, and switches back (s)he will get the rules for the former variable.

After removing context settings, this works as hinting. Load zoo, set some rules for type. Load Iris (rules disappear), set different rules. Go back to zoo and you get the rules back. This hinting is based on variable name.

If this is merged and documentation is updated, close #6961, too.

Includes
  • Code changes
  • Tests

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.03%. Comparing base (246474b) to head (feac944).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7231   +/-   ##
=======================================
  Coverage   89.03%   89.03%           
=======================================
  Files         335      335           
  Lines       74243    74258   +15     
=======================================
+ Hits        66099    66117   +18     
+ Misses       8144     8141    -3     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New layout of “Create class” widget not reflected in docs Create Class: settings seem to change randomly

1 participant