feat(analyze/js/vue): add noVueArrowFuncInWatch
#8602
Conversation
🦋 Changeset detectedLatest commit: 361fe64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-CLI
dyc3
force-pushed
the
dyc3/no-vue-arrow-in-watch
branch
from
a8e3c24 to
67c592b
Compare
ematipico
left a comment
ematipico
left a comment
There was a problem hiding this comment.
This rule would benefit from more tests
| /// } | ||
| /// </script> | ||
| /// ``` | ||
| /// |
There was a problem hiding this comment.
It would be nice to add a link to the official docs
| impl Rule for NoVueArrowFuncInWatch { | ||
| type Query = Semantic<AnyPotentialVueComponent>; | ||
| type State = JsArrowFunctionExpression; | ||
| type Signals = Box<[Self::State]>; |
There was a problem hiding this comment.
I don't think we need a box here. A Vec should be enough
There was a problem hiding this comment.
Every other rule like this uses a Box though
There was a problem hiding this comment.
True that, but I'm not sure we ever proved that it's faster. It's fine, we can keep it.
However , why do we need multiple signals? Why isn't Option<State> enough for this rule?
There was a problem hiding this comment.
It's how our Vue component querying works currently. We query for something that looks like a component, and then we can extract things from it. This makes it so we don't flag things that aren't in vue components.
It would be better if we could provide better queries though.
| handler: (val, oldVal) => { | ||
| console.log('new: %s, old: %s', val, oldVal) | ||
| } |
There was a problem hiding this comment.
Add a test with arrow functions without body e.g.
{
foo: () => ()
}| /* should generate diagnostics */ | ||
| export default { | ||
| watch: { | ||
| foo: (val, oldVal) => { |
There was a problem hiding this comment.
Can we add more cases?
- async token
- TypeScript types
- generator token
dyc3
changed the base branch from
dyc3/use-vue-v-for-key
to
graphite-base/8602
dyc3
force-pushed
the
dyc3/no-vue-arrow-in-watch
branch
from
67c592b to
361fe64
Compare
dyc3
force-pushed
the
graphite-base/8602
branch
from
391e88a to
9a8c98d
Compare
Summary
This adds
noVueArrowFuncInWatch, a port of https://eslint.vuejs.org/rules/no-arrow-functions-in-watch.htmlOnly the code fix was generated by AI.
Test Plan
snapshots, also checked the test cases for the source rule
Docs