feat(linter): add noExcessiveLinesPerFile to CSS and GraphQL #8697
+409
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add shared count_lines_in_file helper to biome_analyze::utils - Refactor JS implementation to use shared helper - Add CSS and GraphQL implementations - Add test specs for both languages Fixes biomejs#8673
🦋 Changeset detectedLatest commit: d2a1903 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
A-Linter
Contributor
WalkthroughImplements the noExcessiveLinesPerFile lint for CSS and GraphQL, adds a shared utility Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks✅ Passed checks (4 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI Agents
In @crates/biome_analyze/src/utils.rs:
- Around line 162-184: The count_lines_in_file function unnecessarily collects
tokens into a Vec inside flat_map and lacks doc clarity: replace the
.flat_map(|descendant| descendant.tokens().collect::<Vec<_>>()) with
.flat_map(|descendant| descendant.tokens()) to avoid allocation, and expand the
function doc comment for count_lines_in_file to state (1) when skip_blank_lines
is true a "line" is counted by presence of leading newlines on tokens (i.e.,
blank lines are ignored), (2) when skip_blank_lines is false a "line" equals
each newline piece in token.leading_trivia after trimming trailing trivia
(explain trimming removes trailing-only trivia that would miscount lines at
token boundaries), and (3) note the +1 offset is to account for the initial
first line before any newline is encountered.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (6)
crates/biome_css_analyze/src/lint/nursery.rsis excluded by!**/nursery.rsand included by**crates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.css.snapis excluded by!**/*.snapand included by**crates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.css.snapis excluded by!**/*.snapand included by**crates/biome_graphql_analyze/src/lint/nursery.rsis excluded by!**/nursery.rsand included by**crates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.graphql.snapis excluded by!**/*.snapand included by**crates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.graphql.snapis excluded by!**/*.snapand included by**
📒 Files selected for processing (13)
.changeset/no-excessive-lines-cross-lang.mdcrates/biome_analyze/src/utils.rscrates/biome_css_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.csscrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.jsoncrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.csscrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.jsoncrates/biome_graphql_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.graphqlcrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.jsoncrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.graphqlcrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.jsoncrates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rs
🧰 Additional context used
📓 Path-based instructions (1)
**/*.rs
📄 CodeRabbit inference engine (CONTRIBUTING.md)
**/*.rs: Use inline rustdoc documentation for rules, assists, and their options
Use thedbg!()macro for debugging output in Rust tests and code
Use doc tests (doctest) format with code blocks in rustdoc comments; ensure assertions pass in tests
Files:
crates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_analyze/src/utils.rscrates/biome_graphql_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_css_analyze/src/lint/nursery/no_excessive_lines_per_file.rs
🧠 Learnings (34)
📓 Common learnings
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : The first paragraph of rule documentation must be written in a single line to ensure proper rendering in the rules overview table
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Implement the `action` function and add `fix_kind` metadata to the rule macro if the rule provides code actions
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : When porting rules from other linters, use `sources` metadata with `RuleSource::Eslint().same()` for identical behavior or `.inspired()` for different behavior
📚 Learning: 2026-01-02T14:58:16.536Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/tests/specs/**/* : Create test files with `invalid` and `valid` prefixes to represent code that should and should not trigger the rule
Applied to files:
crates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.csscrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.graphqlcrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.csscrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.jsoncrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.jsoncrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.jsoncrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.graphqlcrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.json
📚 Learning: 2026-01-02T14:58:16.536Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Invalid code snippets in rule documentation must emit exactly one diagnostic
Applied to files:
crates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.csscrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.graphqlcrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.csscrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.jsoncrates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.jsoncrates/biome_graphql_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.jsoncrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.graphqlcrates/biome_css_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.json
📚 Learning: 2026-01-02T14:58:16.536Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : New rules must be placed inside the `nursery` group before promotion to other groups
Applied to files:
crates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.graphqlcrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.csscrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.jsoncrates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.jsoncrates/biome_graphql_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.jsoncrates/biome_css_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.json
📚 Learning: 2025-12-04T13:29:49.287Z
Learnt from: dyc3
Repo: biomejs/biome PR: 8291
File: crates/biome_html_formatter/tests/specs/prettier/vue/html-vue/elastic-header.html:10-10
Timestamp: 2025-12-04T13:29:49.287Z
Learning: Files under `crates/biome_html_formatter/tests/specs/prettier` are test fixtures synced from Prettier and should not receive detailed code quality reviews (e.g., HTTP vs HTTPS, formatting suggestions, etc.). These files are test data meant to validate formatter behavior and should be preserved as-is.
Applied to files:
crates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.graphqlcrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.csscrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.jsoncrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.graphql
📚 Learning: 2026-01-02T14:58:16.536Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Rule documentation must include an `## Examples` section followed by `### Invalid` and `### Valid` subsections, with Invalid appearing first
Applied to files:
crates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.graphqlcrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.json
📚 Learning: 2026-01-02T14:58:16.536Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : The first paragraph of rule documentation must be written in a single line to ensure proper rendering in the rules overview table
Applied to files:
crates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.css.changeset/no-excessive-lines-cross-lang.mdcrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.jsoncrates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_analyze/src/utils.rscrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.jsoncrates/biome_graphql_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.jsoncrates/biome_css_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.json
📚 Learning: 2026-01-02T14:58:16.536Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/tests/specs/**/*.jsonc : Use `.jsonc` format for test files containing multiple code snippets, where each snippet is a string in an array
Applied to files:
crates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.csscrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.jsoncrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.jsoncrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.jsoncrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.graphqlcrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.json
📚 Learning: 2025-11-24T18:05:20.371Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:20.371Z
Learning: Applies to crates/biome_formatter/**/biome_*_formatter/tests/specs/**/options.json : Create an `options.json` file (formatted as `biome.json`) in test specification folders to apply non-default formatting options to all test files in that folder
Applied to files:
crates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.jsoncrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.jsoncrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.jsoncrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.json
📚 Learning: 2026-01-02T14:58:16.536Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/biome_rule_options/lib/**/*.rs : Rule options must be defined in the `biome_rule_options` crate with a file named after the rule
Applied to files:
crates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.jsoncrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.jsoncrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.json
📚 Learning: 2025-08-05T14:43:29.581Z
Learnt from: dyc3
Repo: biomejs/biome PR: 7081
File: packages/@biomejs/biome/configuration_schema.json:7765-7781
Timestamp: 2025-08-05T14:43:29.581Z
Learning: The file `packages/biomejs/biome/configuration_schema.json` is auto-generated and should not be manually edited or reviewed for schema issues; any changes should be made at the code generation source.
Applied to files:
crates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.jsoncrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.jsoncrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.jsoncrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.json
📚 Learning: 2026-01-02T14:58:16.536Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/biome_rule_options/lib/**/*.rs : Apply `#[serde(deny_unknown_fields)]` to rule option structs to enforce strict configuration validation
Applied to files:
crates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.json
📚 Learning: 2026-01-02T14:58:16.536Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Biome linter rules must be designed to work across languages, requiring careful naming to indicate intended scope
Applied to files:
crates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.jsoncrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.jsoncrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.jsoncrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.json
📚 Learning: 2025-11-21T01:10:53.059Z
Learnt from: dyc3
Repo: biomejs/biome PR: 8171
File: crates/biome_js_analyze/src/lint/nursery/no_leaked_render.rs:125-137
Timestamp: 2025-11-21T01:10:53.059Z
Learning: In the Biome codebase, each lint rule has its own options type declaration (e.g., `type Options = RuleNameOptions`) as part of the codegen process, even if the options struct is empty or unused. This is standard practice and should not be flagged as an issue.
Applied to files:
crates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.jsoncrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.jsoncrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.jsoncrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.json
📚 Learning: 2025-09-25T12:32:59.003Z
Learnt from: arendjr
Repo: biomejs/biome PR: 7593
File: crates/biome_service/src/workspace/server.rs:1306-1306
Timestamp: 2025-09-25T12:32:59.003Z
Learning: In the biomejs/biome project, do not flag compilation errors during code review as they are handled by the existing test infrastructure and CI. Focus on other code quality aspects instead.
Applied to files:
crates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.jsoncrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.jsoncrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.jsoncrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.json
📚 Learning: 2025-12-31T15:35:41.261Z
Learnt from: dyc3
Repo: biomejs/biome PR: 8639
File: crates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rs:101-108
Timestamp: 2025-12-31T15:35:41.261Z
Learning: In crates/biome_analyze/**/*analyze/src/lint/nursery/**/*.rs, the `issue_number` field in `declare_lint_rule!` macro is optional and the vast majority of nursery rules do not need it. Do not recommend adding `issue_number` unless there's a specific reason.
Applied to files:
crates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.jsoncrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.jsoncrates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.jsoncrates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.json
📚 Learning: 2026-01-02T14:58:16.536Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Use helper functions like `map`, `filter`, and `and_then` to avoid excessive nested `if let` statements
Applied to files:
crates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_analyze/src/utils.rs
📚 Learning: 2025-12-31T15:35:32.899Z
Learnt from: dyc3
Repo: biomejs/biome PR: 8639
File: crates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rs:101-108
Timestamp: 2025-12-31T15:35:32.899Z
Learning: In Rust lint rules under the nursery category, the issue_number field in declare_lint_rule! is optional and should not be added unless there is a compelling reason. In code reviews, verify that no unnecessary issue_number is included in nursery lint declarations. Only add issue_number if there is an explicit, justified reason (e.g., tracked issue for external observers). This guidance broadly applies to all nursery lint rule files, not just the single file.
Applied to files:
crates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_graphql_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_css_analyze/src/lint/nursery/no_excessive_lines_per_file.rs
📚 Learning: 2026-01-02T14:58:16.536Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Avoid string allocations by using `&str` or `TokenText` instead of `to_string()`
Applied to files:
crates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_analyze/src/utils.rs
📚 Learning: 2026-01-02T14:58:16.536Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Use `declare_node_union!` macro to query multiple node types together to avoid redundant traversal passes
Applied to files:
crates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_analyze/src/utils.rs
📚 Learning: 2026-01-02T14:58:16.536Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Deprecated rules must include a `deprecated` field in the `declare_lint_rule!` macro with an explanation of what rule to use instead
Applied to files:
crates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_graphql_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_css_analyze/src/lint/nursery/no_excessive_lines_per_file.rs
📚 Learning: 2026-01-02T14:58:16.536Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Use `Markup!` macro for diagnostic messages and code action descriptions to ensure proper formatting
Applied to files:
crates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_css_analyze/src/lint/nursery/no_excessive_lines_per_file.rs
📚 Learning: 2025-12-22T09:26:56.943Z
Learnt from: ematipico
Repo: biomejs/biome PR: 8537
File: crates/biome_js_analyze/src/lint/nursery/no_leaked_render.rs:167-210
Timestamp: 2025-12-22T09:26:56.943Z
Learning: When defining lint rules (declare_lint_rule!), only specify fix_kind if the rule implements an action(...) function. Rules that only emit diagnostics without a code fix should omit fix_kind. This applies to all Rust lint rule definitions under crates/.../src/lint (e.g., crates/biome_js_analyze/src/lint/...).
Applied to files:
crates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_graphql_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_css_analyze/src/lint/nursery/no_excessive_lines_per_file.rs
📚 Learning: 2026-01-02T14:58:16.536Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Use the `Semantic<T>` query type to access semantic information about bindings, references, and scope within a rule
Applied to files:
crates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rs
📚 Learning: 2026-01-02T14:58:16.536Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : When porting rules from other linters, use `sources` metadata with `RuleSource::Eslint().same()` for identical behavior or `.inspired()` for different behavior
Applied to files:
crates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_graphql_analyze/src/lint/nursery/no_excessive_lines_per_file.rs
📚 Learning: 2026-01-02T14:58:16.536Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Code blocks in rule documentation must specify a language identifier and be tagged with `expect_diagnostic` for invalid examples or remain untagged for valid examples
Applied to files:
crates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_graphql_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_css_analyze/src/lint/nursery/no_excessive_lines_per_file.rs
📚 Learning: 2026-01-02T14:58:16.536Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Check if a variable is global using the semantic model before reporting diagnostics for rules that ban global functions or variables
Applied to files:
crates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rs
📚 Learning: 2026-01-02T14:58:16.536Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Rule names should use the `use` prefix when the rule's sole intention is to mandate a single concept
Applied to files:
crates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_graphql_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_css_analyze/src/lint/nursery/no_excessive_lines_per_file.rs
📚 Learning: 2026-01-02T14:58:16.536Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Use `declare_lint_rule!` macro with a `version` field set to `next` for new rules
Applied to files:
crates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_graphql_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_css_analyze/src/lint/nursery/no_excessive_lines_per_file.rs
📚 Learning: 2025-11-24T18:05:20.371Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:20.371Z
Learning: Applies to crates/biome_formatter/**/biome_*_formatter/src/lib.rs : Expose a public `format_node` function that accepts formatting options and a root syntax node, returning a `FormatResult<Formatted<Context>>` with appropriate documentation
Applied to files:
crates/biome_analyze/src/utils.rs
📚 Learning: 2026-01-02T14:58:16.536Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Rule names should use the `no` prefix when the rule's sole intention is to forbid a single concept
Applied to files:
crates/biome_graphql_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_css_analyze/src/lint/nursery/no_excessive_lines_per_file.rs
📚 Learning: 2026-01-02T14:58:16.536Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Implement the `action` function and add `fix_kind` metadata to the rule macro if the rule provides code actions
Applied to files:
crates/biome_graphql_analyze/src/lint/nursery/no_excessive_lines_per_file.rscrates/biome_css_analyze/src/lint/nursery/no_excessive_lines_per_file.rs
📚 Learning: 2026-01-02T14:58:16.536Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Implement the `diagnostic` function to provide error messages explaining what the error is, why it is triggered, and what the user should do
Applied to files:
crates/biome_graphql_analyze/src/lint/nursery/no_excessive_lines_per_file.rs
📚 Learning: 2026-01-02T14:58:16.536Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/biome_rule_options/lib/**/*.rs : Apply `#[serde(rename_all = "camelCase")]` to rule option structs to match JSON configuration naming convention
Applied to files:
crates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.json
🧬 Code graph analysis (2)
crates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rs (1)
crates/biome_analyze/src/utils.rs (1)
count_lines_in_file(163-184)
crates/biome_graphql_analyze/src/lint/nursery/no_excessive_lines_per_file.rs (3)
crates/biome_analyze/src/utils.rs (1)
count_lines_in_file(163-184)crates/biome_css_analyze/src/lint/nursery/no_excessive_lines_per_file.rs (2)
run(70-85)diagnostic(87-103)crates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rs (2)
run(127-142)diagnostic(144-160)
🔇 Additional comments (15)
crates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.json (1)
1-15: LGTM!Test configuration properly set up with
maxLines: 2to validate the rule against the 4-line invalid.css fixture.crates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.json (1)
1-15: LGTM!Test configuration properly set up with
maxLines: 4to validate that the valid.css fixture passes the rule.crates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.graphql (1)
1-4: LGTM!Clean test fixture with four queries to validate the rule's line-counting behaviour.
.changeset/no-excessive-lines-cross-lang.md (1)
1-5: LGTM!Changeset properly formatted with appropriate minor version bump and clear issue reference.
crates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.css (1)
1-4: LGTM!Clean test fixture with four CSS rules to validate the line-counting behaviour.
crates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.options.json (1)
1-15: Configuration looks correct.The test options file is properly structured with an appropriate
maxLineslimit for the valid test case.crates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.graphql (1)
1-3: Test fixture is appropriate.The 3-line fixture correctly tests the valid case against the
maxLines: 4configuration.crates/biome_graphql_analyze/tests/specs/nursery/noExcessiveLinesPerFile/invalid.options.json (1)
1-15: Configuration looks correct.The
maxLines: 2setting is appropriate for testing the invalid case where diagnostics should be triggered.crates/biome_css_analyze/tests/specs/nursery/noExcessiveLinesPerFile/valid.css (1)
1-3: Test fixture is appropriate.The CSS fixture follows the same simple pattern as the GraphQL test, which is good for consistency.
crates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rs (2)
3-3: Clean refactor to use shared utility.The import of
count_lines_in_fileenables code reuse across language implementations.
131-135: Correctly delegates line counting to the shared utility.The function call properly passes the EOF token predicate and the
skip_blank_linesoption, maintaining the original behaviour whilst eliminating code duplication.crates/biome_graphql_analyze/src/lint/nursery/no_excessive_lines_per_file.rs (2)
64-103: LGTM!The rule implementation correctly uses the shared
count_lines_in_fileutility, properly detects EOF tokens, and provides a clear diagnostic message with the line count and limit.
10-13: Consolidate the first paragraph into a single line.The first paragraph must be written as a single line to ensure proper rendering in the rules overview table.
Based on learnings, this applies to all rule documentation in
biome_analyze/**/*_analyze/**/src/lint/**/*.rs.🔎 Proposed fix
- /// Restrict the number of lines in a file. - /// - /// Large files tend to do many things and can make it hard to follow what's going on. - /// This rule can help enforce a limit on the number of lines in a file. + /// Restrict the number of lines in a file to improve maintainability and readability by preventing excessively large files. + /// + /// Large files tend to do many things and can make it hard to follow what's going on. This rule can help enforce a limit on the number of lines in a file.⛔ Skipped due to learnings
Learnt from: CR Repo: biomejs/biome PR: 0 File: crates/biome_analyze/CONTRIBUTING.md:0-0 Timestamp: 2026-01-02T14:58:16.536Z Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : The first paragraph of rule documentation must be written in a single line to ensure proper rendering in the rules overview tableLearnt from: CR Repo: biomejs/biome PR: 0 File: crates/biome_analyze/CONTRIBUTING.md:0-0 Timestamp: 2026-01-02T14:58:16.536Z Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Invalid code snippets in rule documentation must emit exactly one diagnosticLearnt from: dyc3 Repo: biomejs/biome PR: 8639 File: crates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rs:101-108 Timestamp: 2025-12-31T15:35:41.261Z Learning: In crates/biome_analyze/**/*analyze/src/lint/nursery/**/*.rs, the `issue_number` field in `declare_lint_rule!` macro is optional and the vast majority of nursery rules do not need it. Do not recommend adding `issue_number` unless there's a specific reason.Learnt from: CR Repo: biomejs/biome PR: 0 File: crates/biome_analyze/CONTRIBUTING.md:0-0 Timestamp: 2026-01-02T14:58:16.536Z Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Rule documentation must include an `## Examples` section followed by `### Invalid` and `### Valid` subsections, with Invalid appearing firstLearnt from: ematipico Repo: biomejs/biome PR: 8537 File: crates/biome_js_analyze/src/lint/nursery/no_leaked_render.rs:167-210 Timestamp: 2025-12-22T09:27:13.161Z Learning: In crates/biome_analyze/**/*analyze/src/**/*.rs, the `fix_kind` field in `declare_lint_rule!` should only be specified when the rule implements the `action` function. Rules that only emit diagnostics without providing code fixes should not include `fix_kind` in their metadata.Learnt from: CR Repo: biomejs/biome PR: 0 File: crates/biome_analyze/CONTRIBUTING.md:0-0 Timestamp: 2026-01-02T14:58:16.536Z Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Code blocks in rule documentation must specify a language identifier and be tagged with `expect_diagnostic` for invalid examples or remain untagged for valid examplesLearnt from: CR Repo: biomejs/biome PR: 0 File: crates/biome_analyze/CONTRIBUTING.md:0-0 Timestamp: 2026-01-02T14:58:16.536Z Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Rule names should use the `no` prefix when the rule's sole intention is to forbid a single conceptLearnt from: CR Repo: biomejs/biome PR: 0 File: crates/biome_analyze/CONTRIBUTING.md:0-0 Timestamp: 2026-01-02T14:58:16.536Z Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : New rules must be placed inside the `nursery` group before promotion to other groupsLearnt from: CR Repo: biomejs/biome PR: 0 File: crates/biome_analyze/CONTRIBUTING.md:0-0 Timestamp: 2026-01-02T14:58:16.536Z Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Deprecated rules must include a `deprecated` field in the `declare_lint_rule!` macro with an explanation of what rule to use insteadLearnt from: CR Repo: biomejs/biome PR: 0 File: crates/biome_analyze/CONTRIBUTING.md:0-0 Timestamp: 2026-01-02T14:58:16.536Z Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Use `declare_lint_rule!` macro with a `version` field set to `next` for new rulescrates/biome_css_analyze/src/lint/nursery/no_excessive_lines_per_file.rs (2)
64-103: LGTM!The CSS rule implementation mirrors the GraphQL variant correctly, using the shared utility and providing clear diagnostics.
10-13: Consolidate the first paragraph into a single line.Same issue as the GraphQL rule: the first paragraph must be written as a single line to ensure proper rendering in the rules overview table.
Based on learnings, this applies to all rule documentation in
biome_analyze/**/*_analyze/**/src/lint/**/*.rs.🔎 Proposed fix
- /// Restrict the number of lines in a file. - /// - /// Large files tend to do many things and can make it hard to follow what's going on. - /// This rule can help enforce a limit on the number of lines in a file. + /// Restrict the number of lines in a file to improve maintainability and readability by preventing excessively large files. + /// + /// Large files tend to do many things and can make it hard to follow what's going on. This rule can help enforce a limit on the number of lines in a file.⛔ Skipped due to learnings
Learnt from: CR Repo: biomejs/biome PR: 0 File: crates/biome_analyze/CONTRIBUTING.md:0-0 Timestamp: 2026-01-02T14:58:16.536Z Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : The first paragraph of rule documentation must be written in a single line to ensure proper rendering in the rules overview tableLearnt from: CR Repo: biomejs/biome PR: 0 File: crates/biome_analyze/CONTRIBUTING.md:0-0 Timestamp: 2026-01-02T14:58:16.536Z Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Invalid code snippets in rule documentation must emit exactly one diagnosticLearnt from: dyc3 Repo: biomejs/biome PR: 8639 File: crates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rs:101-108 Timestamp: 2025-12-31T15:35:41.261Z Learning: In crates/biome_analyze/**/*analyze/src/lint/nursery/**/*.rs, the `issue_number` field in `declare_lint_rule!` macro is optional and the vast majority of nursery rules do not need it. Do not recommend adding `issue_number` unless there's a specific reason.Learnt from: CR Repo: biomejs/biome PR: 0 File: crates/biome_analyze/CONTRIBUTING.md:0-0 Timestamp: 2026-01-02T14:58:16.536Z Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Rule documentation must include an `## Examples` section followed by `### Invalid` and `### Valid` subsections, with Invalid appearing firstLearnt from: CR Repo: biomejs/biome PR: 0 File: crates/biome_analyze/CONTRIBUTING.md:0-0 Timestamp: 2026-01-02T14:58:16.536Z Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Rule names should use the `no` prefix when the rule's sole intention is to forbid a single conceptLearnt from: ematipico Repo: biomejs/biome PR: 8537 File: crates/biome_js_analyze/src/lint/nursery/no_leaked_render.rs:167-210 Timestamp: 2025-12-22T09:27:13.161Z Learning: In crates/biome_analyze/**/*analyze/src/**/*.rs, the `fix_kind` field in `declare_lint_rule!` should only be specified when the rule implements the `action` function. Rules that only emit diagnostics without providing code fixes should not include `fix_kind` in their metadata.Learnt from: CR Repo: biomejs/biome PR: 0 File: crates/biome_analyze/CONTRIBUTING.md:0-0 Timestamp: 2026-01-02T14:58:16.536Z Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Code blocks in rule documentation must specify a language identifier and be tagged with `expect_diagnostic` for invalid examples or remain untagged for valid examplesLearnt from: CR Repo: biomejs/biome PR: 0 File: crates/biome_analyze/CONTRIBUTING.md:0-0 Timestamp: 2026-01-02T14:58:16.536Z Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : New rules must be placed inside the `nursery` group before promotion to other groupsLearnt from: CR Repo: biomejs/biome PR: 0 File: crates/biome_analyze/CONTRIBUTING.md:0-0 Timestamp: 2026-01-02T14:58:16.536Z Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Rule names should use the `use` prefix when the rule's sole intention is to mandate a single conceptLearnt from: CR Repo: biomejs/biome PR: 0 File: crates/biome_analyze/CONTRIBUTING.md:0-0 Timestamp: 2026-01-02T14:58:16.536Z Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Deprecated rules must include a `deprecated` field in the `declare_lint_rule!` macro with an explanation of what rule to use instead
Comment on lines
+162
to
+184
| /// Counts lines in a syntax tree, used by `noExcessiveLinesPerFile`. | ||
| pub fn count_lines_in_file<L: Language>( | ||
| node: &SyntaxNode<L>, | ||
| is_eof_token: impl Fn(&SyntaxToken<L>) -> bool, | ||
| skip_blank_lines: bool, | ||
| ) -> usize { | ||
| node.descendants() | ||
| .flat_map(|descendant| descendant.tokens().collect::<Vec<_>>()) | ||
| .filter(|token| !is_eof_token(token)) | ||
| .fold(0, |acc, token| { | ||
| if skip_blank_lines { | ||
| return acc + token.has_leading_newline() as usize; | ||
| } | ||
|
|
||
| acc + token | ||
| .trim_trailing_trivia() | ||
| .leading_trivia() | ||
| .pieces() | ||
| .filter(|piece| piece.is_newline()) | ||
| .count() | ||
| }) | ||
| + 1 // Add 1 for the first line | ||
| } |
Contributor
There was a problem hiding this comment.
🛠️ Refactor suggestion | 🟠 Major
Optimise token traversal and clarify line-counting semantics.
Two points:
-
Line 169: Collecting to
Vecwithinflat_mapis unnecessary—flat_mapalready flattens iterators. Replace.flat_map(|descendant| descendant.tokens().collect::<Vec<_>>())with.flat_map(|descendant| descendant.tokens()). -
Documentation gap: The current comment doesn't explain when each mode applies or what "line" means in each case. Add a doc comment clarifying:
- What constitutes a "line" when
skip_blank_linesis true vs false - Why trailing trivia is trimmed in the false case
- The rationale for the
+ 1offset
- What constitutes a "line" when
🔎 Proposed fix
+/// Counts lines in a syntax tree, used by `noExcessiveLinesPerFile`.
+///
+/// When `skip_blank_lines` is `true`, counts only tokens that introduce a new line
+/// (have a leading newline in their trivia).
+///
+/// When `skip_blank_lines` is `false`, counts all newline trivia pieces in each token's
+/// leading trivia after trimming trailing trivia from the previous token.
+///
+/// Tokens matching `is_eof_token` are excluded from the count.
+///
+/// Returns the total line count, including line 1.
-/// Counts lines in a syntax tree, used by `noExcessiveLinesPerFile`.
pub fn count_lines_in_file<L: Language>(
node: &SyntaxNode<L>,
is_eof_token: impl Fn(&SyntaxToken<L>) -> bool,
skip_blank_lines: bool,
) -> usize {
node.descendants()
- .flat_map(|descendant| descendant.tokens().collect::<Vec<_>>())
+ .flat_map(|descendant| descendant.tokens())
.filter(|token| !is_eof_token(token))
.fold(0, |acc, token| {
if skip_blank_lines {
return acc + token.has_leading_newline() as usize;
}
acc + token
.trim_trailing_trivia()
.leading_trivia()
.pieces()
.filter(|piece| piece.is_newline())
.count()
})
+ 1 // Add 1 for the first line
}🤖 Prompt for AI Agents
In @crates/biome_analyze/src/utils.rs around lines 162-184, The
count_lines_in_file function unnecessarily collects tokens into a Vec inside
flat_map and lacks doc clarity: replace the .flat_map(|descendant|
descendant.tokens().collect::<Vec<_>>()) with .flat_map(|descendant|
descendant.tokens()) to avoid allocation, and expand the function doc comment
for count_lines_in_file to state (1) when skip_blank_lines is true a "line" is
counted by presence of leading newlines on tokens (i.e., blank lines are
ignored), (2) when skip_blank_lines is false a "line" equals each newline piece
in token.leading_trivia after trimming trailing trivia (explain trimming removes
trailing-only trivia that would miscount lines at token boundaries), and (3)
note the +1 offset is to account for the initial first line before any newline
is encountered.
Netail
reviewed
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
noExcessiveLinesPerFilerule to CSS and GraphQL by extracting shared logic intobiome_analyze::utils::count_lines_in_file.Fixes #8673
Test plan
cargo test -p biome_css_analyze -- no_excessive_lines_per_filecargo test -p biome_graphql_analyze -- no_excessive_lines_per_filecargo test -p biome_js_analyze -- no_excessive_lines_per_file