Open
Conversation
…amter to update logic and cleaned print output
Collaborator
|
@NikkiBytes is this ready to be merged to dev and tested? |
Contributor
Author
|
@marcodarko ready for a final review from @newgene and then we can merge. I added notes to the summary above about additional name convention changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds automated monthly updates for schema.org to keep the registry in sync with the latest schema.org releases.
New Features
• Monthly schema.org update routine (
discovery/utils/update.py)◦ Compares current stored version against latest schema.org version
◦ Performs dry-run validation before applying updates
◦ Comprehensive error handling for
RegistryErrorandAttributeErrorwith detailed logging• Scheduled execution (
index.py)◦ Runs monthly on the 1st at 2 AM (
cron: 0 2 1 * *)◦ Executes in a separate thread to avoid blocking
Modified
•
_add_schema_class– New schema_org_version and dryrun parameters for version-specific validation•
add_core– Now accepts version parameter and stores version after updateFunction renames across the codebase — This is a significant API change:
◦
get_schema_org_version()→get_stored_schema_org_version()(inschemas.py, clarifies it reads from ES metadata)◦
get_schema_org_version()→get_latest_schema_org_version()(inadapters.py, clarifies it fetches from biothings_schema)◦ These renames are updated through
schema.pyhandler,schemas.py,adapters.py, and all tests