Bump version v2.8.5#161
Merged
Merged
Conversation
…ng in execute method
…d correct label for middle_name
RishadAlam
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request bumps the version to 2.8.5 and addresses several bugs across Copper CRM, Keap, and TagifyInput integrations. Key changes include improved field mapping logic, corrected contact fields for Keap, and updated changelog information. Review feedback suggests removing a leftover debug error_log in the Copper CRM helper and an unused lodash import in the TagifyInput component.
✅ WordPress Plugin Check Report
📊 ReportAll checks passed! No errors or warnings found. 🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check |
There was a problem hiding this comment.
Pull request overview
Prepares the v2.8.5 release by fixing Keap and Copper CRM field-mapping issues, tightening Tagify field suggestion behavior, and updating release metadata/changelogs across the plugin.
Changes:
- Fix Keap contact field mapping (correct middle-name label; add last-name mapping key).
- Fix Copper CRM mapping to resolve trigger/custom values more safely.
- Update Tagify dropdown limiting and bump version/changelog references to
2.8.5.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| readme.txt | Updates stable tag + adds 2.8.5 changelog entry. |
| frontend/src/pages/ChangelogToggle.jsx | Updates in-admin “What’s New” modal content for the 13th May 2026 release. |
| frontend/src/components/Utilities/TagifyInput.jsx | Adjusts Tagify dropdown configuration to cap suggestion items. |
| frontend/src/components/AllIntegrations/Keap/Keap.jsx | Corrects Keap contact field definitions (middle/last name mapping). |
| frontend/src/components/AllIntegrations/CopperCRM/IntegrationHelpers.jsx | Updates Copper CRM custom-value handlers to accept non-event values. |
| backend/Actions/CopperCRM/RecordApiHelper.php | Fixes Copper CRM request-data generation from field map; adds debug logging (needs removal). |
| bitwpfi.php | Bumps plugin header/constant version to 2.8.5. |
| backend/Config.php | Bumps backend Config::VERSION to 2.8.5. |
Comments suppressed due to low confidence (1)
frontend/src/components/AllIntegrations/CopperCRM/IntegrationHelpers.jsx:42
- Same issue as
handleCustomValue:event?.target?.value || event || ''will treat empty string as falsy and can assign the entire event object into the field map. Use??(or explicittypeof ... !== 'undefined') so clearing the field results in an empty string, not an object.
newConf.field_map[index][fieldValue] = event?.target?.value || event || ''
setConf({ ...newConf })
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /* eslint-disable jsx-a11y/label-has-associated-control */ | ||
| import Tagify from '@yaireo/tagify' | ||
| import '@yaireo/tagify/dist/tagify.css' | ||
| import { max } from 'lodash' |
Comment on lines
+35
to
36
| newConf.field_map[index].customValue = event?.target?.value || event || '' | ||
| setConf({ ...newConf }) |
| public function execute($fieldValues, $fieldMap, $actionName) | ||
| { | ||
| $finalData = $this->generateReqDataFromFieldMap($fieldValues, $fieldMap); | ||
| error_log('final data' . print_r($finalData, true)); |
Comment on lines
+474
to
+476
| - **Bug Fixes** | ||
| - Keap: Added missing `last_name` contact field and corrected `middle_name` label. | ||
| - Copper CRM: Fixed field mapping for custom values and mapped trigger fields. |
Comment on lines
58
to
61
| { | ||
| label: 'MailerLite', | ||
| desc: 'Fixed blank page issue.', | ||
| isPro: false | ||
| }, | ||
| { | ||
| label: 'FluentCRM', | ||
| desc: 'Fixed logo handling and added missing assets.', | ||
| label: 'Keap', | ||
| desc: 'Added missing `last_name` contact field and corrected `middle_name` label.', | ||
| isPro: false |
abdul-kaioum
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR prepares
v2.8.5with integration bug fixes across Keap and Copper CRM, plus changelog updates in plugin docs and admin changelog UI. It also improves Tagify mapping behavior to prevent dropdown selection edge cases during field mapping.Motivation & Context
Users were seeing incorrect or missing contact mapping fields, plus unstable custom value handling in Copper CRM mapping inputs. This update fixes mapping reliability and aligns release metadata/changelog for the new stable tag.
Related Links: (if applicable)
Type of Change
Key Changes
Integrations
middle_namelabel and adding missingfamily_namemapping key.Frontend
ChangelogToggle) for13th May 2026release notes.Release & Docs
2.8.5in config/bootstrap constants.readme.txtstable tag and added2.8.5changelog entry.Checklist
Changelog
v2.8.5release details.