Skip to content

ci: Add NetBSD job #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ci: Add NetBSD job #196

wants to merge 1 commit into from
+28 −0

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Aug 23, 2025 •
edited
Loading

@DrahtBot
Copy link

DrahtBot commented Aug 23, 2025 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

@hebasto hebasto mentioned this pull request Aug 23, 2025
Open
hebasto added a commit to hebasto/bitcoin-core-nightly that referenced this pull request Aug 23, 2025
@hebasto
NetBSD: Temporarily disable IPC in "system libs" job
ff81a4a 
See: bitcoin-core/libmultiprocess#196.
hebasto added a commit to hebasto/bitcoin-core-nightly that referenced this pull request Aug 23, 2025
@hebasto
NetBSD: Temporarily disable IPC in "system libs" job
cc1420b 
See: bitcoin-core/libmultiprocess#196.
hebasto
hebasto commented Aug 23, 2025
View reviewed changes
@hebasto
ci: Add NetBSD job
5852983 
Add `pkg-config` package
@ryanofsky
Copy link
Collaborator

Errors all appear to be undefined reference to 'kj::getCaughtExceptionAsKj()' linker errors

@hebasto hebasto closed this Aug 23, 2025
@hebasto hebasto reopened this Aug 23, 2025
@ryanofsky
Copy link
Collaborator

I noticed getCaughtExceptionAsKj doesn't seem to be defined if KJ_NO_EXCEPTIONS is defined. Doesn't look like netbsd is defining that though https://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/devel/capnproto/

@ryanofsky ryanofsky closed this Aug 23, 2025
@ryanofsky ryanofsky reopened this Aug 23, 2025
maflcko
maflcko reviewed Aug 24, 2025
View reviewed changes
.github/workflows/ci.yml

- name: Run CI script
run: |
cd ${{ github.workspace }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Could address #195 (comment) while touching this file?

Copy link
Member Author

@hebasto hebasto Aug 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Could address #195 (comment) while touching this file?

Responded here.

UPD. If this line is dropped, the job fails:

bash: ci/scripts/ci.sh: No such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanofsky ryanofsky ryanofsky left review comments

+1 more reviewer

@maflcko maflcko maflcko left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hebasto @DrahtBot @ryanofsky @maflcko