Skip to content

Add intel simd #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Add intel simd #1703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d4cfad0
Add simd to field5x52
Raimo33 Jul 18, 2025
47e803d
Fix declaration after statement
Raimo33 Jul 18, 2025
3b4f8d2
Add MSVC bswap
Raimo33 Jul 18, 2025
c636aad
Fix undeclared vars
Raimo33 Jul 18, 2025
c963872
Fix header conflict in ARM
Raimo33 Jul 18, 2025
63ec51b
Add bswap define
Raimo33 Jul 18, 2025
ee535bf
Remove .vscode
Raimo33 Jul 18, 2025
22e9772
Fix endianess dependent code
Raimo33 Jul 18, 2025
c351b78
Fix endian detection macro
Raimo33 Jul 18, 2025
5d8a8f9
Optimize write_be and read_be
Raimo33 Jul 18, 2025
d00ba2d
Optimize mul_cmp
Raimo33 Jul 18, 2025
58316e9
Optimize sha256_initialize, Add TODOs
Raimo33 Jul 18, 2025
f974f03
Add simd to scalar_4x64, Add TODOs
Raimo33 Jul 18, 2025
f16528f
Add TODOs
Raimo33 Jul 18, 2025
9756db9
Add TODOs [skip ci]
Raimo33 Jul 19, 2025
4b21212
Remove junk folders [skip ci]
Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 45 additions & 5 deletions src/field_10x26_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ static void secp256k1_fe_impl_verify(const secp256k1_fe *a) {
#endif

static void secp256k1_fe_impl_get_bounds(secp256k1_fe *r, int m) {

/* TODO: parallelize, SSE2 (32bit cpu only) */

r->n[0] = 0x3FFFFFFUL * 2 * m;
r->n[1] = 0x3FFFFFFUL * 2 * m;
r->n[2] = 0x3FFFFFFUL * 2 * m;
Expand Down Expand Up @@ -258,11 +261,17 @@ static int secp256k1_fe_impl_normalizes_to_zero_var(const secp256k1_fe *r) {

SECP256K1_INLINE static void secp256k1_fe_impl_set_int(secp256k1_fe *r, int a) {
r->n[0] = a;

/* TODO: parallelize, SSE2 (32bit cpu only) */

r->n[1] = r->n[2] = r->n[3] = r->n[4] = r->n[5] = r->n[6] = r->n[7] = r->n[8] = r->n[9] = 0;
}

SECP256K1_INLINE static int secp256k1_fe_impl_is_zero(const secp256k1_fe *a) {
const uint32_t *t = a->n;

/* TODO: parallelize, SSE2 (32bit cpu only) */

return (t[0] | t[1] | t[2] | t[3] | t[4] | t[5] | t[6] | t[7] | t[8] | t[9]) == 0;
}

Expand All @@ -272,18 +281,20 @@ SECP256K1_INLINE static int secp256k1_fe_impl_is_odd(const secp256k1_fe *a) {

static int secp256k1_fe_impl_cmp_var(const secp256k1_fe *a, const secp256k1_fe *b) {
int i;
int diff;
for (i = 9; i >= 0; i--) {
if (a->n[i] > b->n[i]) {
return 1;
}
if (a->n[i] < b->n[i]) {
return -1;
diff = (a->n[i] > b->n[i]) - (a->n[i] < b->n[i]);
if (diff != 0) {
return diff;
}
}
return 0;
}

static void secp256k1_fe_impl_set_b32_mod(secp256k1_fe *r, const unsigned char *a) {

/* TODO: parallelize, SSE2 (32bit cpu only) */

r->n[0] = (uint32_t)a[31] | ((uint32_t)a[30] << 8) | ((uint32_t)a[29] << 16) | ((uint32_t)(a[28] & 0x3) << 24);
r->n[1] = (uint32_t)((a[28] >> 2) & 0x3f) | ((uint32_t)a[27] << 6) | ((uint32_t)a[26] << 14) | ((uint32_t)(a[25] & 0xf) << 22);
r->n[2] = (uint32_t)((a[25] >> 4) & 0xf) | ((uint32_t)a[24] << 4) | ((uint32_t)a[23] << 12) | ((uint32_t)(a[22] & 0x3f) << 20);
Expand All @@ -303,6 +314,9 @@ static int secp256k1_fe_impl_set_b32_limit(secp256k1_fe *r, const unsigned char

/** Convert a field element to a 32-byte big endian value. Requires the input to be normalized */
static void secp256k1_fe_impl_get_b32(unsigned char *r, const secp256k1_fe *a) {

/* TODO: parallelize, SSE2 (32bit cpu only) */

r[0] = (a->n[9] >> 14) & 0xff;
r[1] = (a->n[9] >> 6) & 0xff;
r[2] = ((a->n[9] & 0x3F) << 2) | ((a->n[8] >> 24) & 0x3);
Expand Down Expand Up @@ -346,6 +360,9 @@ SECP256K1_INLINE static void secp256k1_fe_impl_negate_unchecked(secp256k1_fe *r,

/* Due to the properties above, the left hand in the subtractions below is never less than
* the right hand. */

/* TODO: parallelize, SSE2 (32bit cpu only) */

r->n[0] = 0x3FFFC2FUL * 2 * (m + 1) - a->n[0];
r->n[1] = 0x3FFFFBFUL * 2 * (m + 1) - a->n[1];
r->n[2] = 0x3FFFFFFUL * 2 * (m + 1) - a->n[2];
Expand All @@ -359,6 +376,8 @@ SECP256K1_INLINE static void secp256k1_fe_impl_negate_unchecked(secp256k1_fe *r,
}

SECP256K1_INLINE static void secp256k1_fe_impl_mul_int_unchecked(secp256k1_fe *r, int a) {
/* TODO: parallelize, SSE2 (32bit cpu only) */

r->n[0] *= a;
r->n[1] *= a;
r->n[2] *= a;
Expand All @@ -372,6 +391,8 @@ SECP256K1_INLINE static void secp256k1_fe_impl_mul_int_unchecked(secp256k1_fe *r
}

SECP256K1_INLINE static void secp256k1_fe_impl_add(secp256k1_fe *r, const secp256k1_fe *a) {
/* TODO: parallelize, SSE2 (32bit cpu only) */

r->n[0] += a->n[0];
r->n[1] += a->n[1];
r->n[2] += a->n[2];
Expand Down Expand Up @@ -1017,6 +1038,10 @@ SECP256K1_INLINE static void secp256k1_fe_impl_cmov(secp256k1_fe *r, const secp2
SECP256K1_CHECKMEM_CHECK_VERIFY(r->n, sizeof(r->n));
mask0 = vflag + ~((uint32_t)0);
mask1 = ~mask0;


/* TODO: parallelize, SSE2 (32bit cpu only) */

r->n[0] = (r->n[0] & mask0) | (a->n[0] & mask1);
r->n[1] = (r->n[1] & mask0) | (a->n[1] & mask1);
r->n[2] = (r->n[2] & mask0) | (a->n[2] & mask1);
Expand Down Expand Up @@ -1065,6 +1090,8 @@ static SECP256K1_INLINE void secp256k1_fe_impl_half(secp256k1_fe *r) {
* t9 <= D * (m + 1/2)
*/

/* TODO: parallelize, SSE2 (32bit cpu only) */

r->n[0] = (t0 >> 1) + ((t1 & one) << 25);
r->n[1] = (t1 >> 1) + ((t2 & one) << 25);
r->n[2] = (t2 >> 1) + ((t3 & one) << 25);
Expand Down Expand Up @@ -1100,6 +1127,9 @@ static SECP256K1_INLINE void secp256k1_fe_storage_cmov(secp256k1_fe_storage *r,
SECP256K1_CHECKMEM_CHECK_VERIFY(r->n, sizeof(r->n));
mask0 = vflag + ~((uint32_t)0);
mask1 = ~mask0;

/* TODO: parallelize, SSE2 (32bit cpu only) */

r->n[0] = (r->n[0] & mask0) | (a->n[0] & mask1);
r->n[1] = (r->n[1] & mask0) | (a->n[1] & mask1);
r->n[2] = (r->n[2] & mask0) | (a->n[2] & mask1);
Expand All @@ -1111,6 +1141,9 @@ static SECP256K1_INLINE void secp256k1_fe_storage_cmov(secp256k1_fe_storage *r,
}

static void secp256k1_fe_impl_to_storage(secp256k1_fe_storage *r, const secp256k1_fe *a) {

/* TODO: parallelize, SSE2 (32bit cpu only) */

r->n[0] = a->n[0] | a->n[1] << 26;
r->n[1] = a->n[1] >> 6 | a->n[2] << 20;
r->n[2] = a->n[2] >> 12 | a->n[3] << 14;
Expand All @@ -1123,6 +1156,9 @@ static void secp256k1_fe_impl_to_storage(secp256k1_fe_storage *r, const secp256k

static SECP256K1_INLINE void secp256k1_fe_impl_from_storage(secp256k1_fe *r, const secp256k1_fe_storage *a) {
r->n[0] = a->n[0] & 0x3FFFFFFUL;

/* TODO: parallelize, SSE2 (32bit cpu only) */

r->n[1] = a->n[0] >> 26 | ((a->n[1] << 6) & 0x3FFFFFFUL);
r->n[2] = a->n[1] >> 20 | ((a->n[2] << 12) & 0x3FFFFFFUL);
r->n[3] = a->n[2] >> 14 | ((a->n[3] << 18) & 0x3FFFFFFUL);
Expand Down Expand Up @@ -1152,6 +1188,8 @@ static void secp256k1_fe_from_signed30(secp256k1_fe *r, const secp256k1_modinv32
VERIFY_CHECK(a7 >> 30 == 0);
VERIFY_CHECK(a8 >> 16 == 0);

/* TODO: parallelize, SSE2 (32bit cpu only) */

r->n[0] = a0 & M26;
r->n[1] = (a0 >> 26 | a1 << 4) & M26;
r->n[2] = (a1 >> 22 | a2 << 8) & M26;
Expand All @@ -1169,6 +1207,8 @@ static void secp256k1_fe_to_signed30(secp256k1_modinv32_signed30 *r, const secp2
const uint64_t a0 = a->n[0], a1 = a->n[1], a2 = a->n[2], a3 = a->n[3], a4 = a->n[4],
a5 = a->n[5], a6 = a->n[6], a7 = a->n[7], a8 = a->n[8], a9 = a->n[9];

/* TODO: parallelize, SSE2 (32bit cpu only) */

r->v[0] = (a0 | a1 << 26) & M30;
r->v[1] = (a1 >> 4 | a2 << 22) & M30;
r->v[2] = (a2 >> 8 | a3 << 18) & M30;
Expand Down
Loading