SleepMode rename #724
Merged
SleepMode rename #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Comparison Report (x86_64)
|
There was a problem hiding this comment.
Pull Request Overview
This PR renames the SleepMode enum values from .active/.inactive to .enabled/.disabled across both Swift and Kotlin platforms to improve naming clarity and consistency.
- Renamed
SleepMode.activetoSleepMode.enabledandSleepMode.inactivetoSleepMode.disabled - Updated all references to use the new enum values throughout the codebase
- Updated documentation comments to reflect the new naming
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| platform/swift/source/features/SleepMode.swift | Renamed enum cases from active/inactive to enabled/disabled |
| platform/jvm/capture/src/main/kotlin/io/bitdrift/capture/SleepMode.kt | Renamed enum cases from ACTIVE/INACTIVE to ENABLED/DISABLED |
| platform/swift/source/features/Configuration.swift | Updated default value and documentation to use disabled |
| platform/swift/source/LoggerObjc.swift | Updated documentation and default parameter value |
| platform/swift/source/LoggerBridgingFactoryProvider.swift | Updated documentation comment |
| platform/swift/source/LoggerBridge.swift | Updated enum comparisons to use enabled |
| platform/jvm/capture/src/main/kotlin/io/bitdrift/capture/LoggerImpl.kt | Updated enum comparisons to use ENABLED |
| platform/jvm/capture/src/main/kotlin/io/bitdrift/capture/Configuration.kt | Updated default value and documentation |
| test/platform/swift/unit_integration/mocks/MockLogging.swift | Updated default value to disabled |
| test/platform/swift/unit_integration/mocks/MockLoggerBridging.swift | Updated default value to disabled |
| test/platform/swift/unit_integration/core/network/helper/BaseNetworkingTestCase.swift | Updated test initialization to use disabled |
| test/platform/swift/unit_integration/core/LoggerTests.swift | Updated test to use enabled |
| test/platform/swift/unit_integration/core/ConfigurationTests.swift | Updated test assertion to check disabled |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
FranAguilera
force-pushed
the
franjam/rename-sleep-mode
branch
from
0d64125 to
34ed4bd
Compare
murki
approved these changes
Nov 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change
Will update public docs on next release