Add ability to send event to UI to rerender menu

src/auto-updater/index.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const { app, ipcMain, Menu } = require('electron')
+const { app, ipcMain } = require('electron')
 const { rootPath: appDir } = require('electron-root-path')
 const fs = require('fs')
 const path = require('path')
@@ -40,6 +40,7 @@ const ThemeIpcChannelHandlers = require(
 )
 
 const MENU_ITEM_IDS = require('../create-menu/menu.item.ids')
+const { changeMenuItemStatesById } = require('../create-menu/utils')
 
 const isAutoUpdateDisabled = parseEnvValToBool(process.env.IS_AUTO_UPDATE_DISABLED)
 
@@ -231,46 +232,32 @@ const _fireToast = (
   return res
 }
 
-const _getUpdateMenuItemById = (id) => {
-  const menu = Menu.getApplicationMenu()
-
-  if (
-    !menu ||
-    !id ||
-    typeof id !== 'string'
-  ) {
-    return
-  }
-
-  return menu.getMenuItemById(id)
-}
-
-const _switchMenuItem = (opts = {}) => {
+const _switchMenuItem = (opts) => {
   const {
     isCheckMenuItemDisabled,
     isInstallMenuItemVisible
-  } = { ...opts }
-  const checkMenuItem = _getUpdateMenuItemById(
-    MENU_ITEM_IDS.CHECK_UPDATE_MENU_ITEM
-  )
-  const installMenuItem = _getUpdateMenuItemById(
-    MENU_ITEM_IDS.INSTALL_UPDATE_MENU_ITEM
-  )
-
-  if (
-    !checkMenuItem ||
-    !installMenuItem
-  ) {
-    return
-  }
+  } = opts ?? {}
+  const checkMenuItemOpts = {}
+  const installMenuItemOpts = {}
 
   if (typeof isCheckMenuItemDisabled === 'boolean') {
-    checkMenuItem.enabled = !isCheckMenuItemDisabled
+    checkMenuItemOpts.enabled = !isCheckMenuItemDisabled
   }
   if (typeof isInstallMenuItemVisible === 'boolean') {
-    checkMenuItem.visible = !isInstallMenuItemVisible
-    installMenuItem.visible = isInstallMenuItemVisible
+    checkMenuItemOpts.visible = !isInstallMenuItemVisible
+    installMenuItemOpts.visible = isInstallMenuItemVisible
   }
+
+  changeMenuItemStatesById([
+    {
+      menuItemId: MENU_ITEM_IDS.CHECK_UPDATE_MENU_ITEM,
+      opts: checkMenuItemOpts
+    },
+    {
+      menuItemId: MENU_ITEM_IDS.INSTALL_UPDATE_MENU_ITEM,
+      opts: installMenuItemOpts
+    }
+  ])
 }
 
 const _reinitInterval = () => {

src/changelog-manager/show-changelog.js

@@ -1,6 +1,5 @@
 'use strict'
 
-const { Menu } = require('electron')
 const path = require('path')
 const parseChangelog = require('changelog-parser')
 const { rootPath } = require('electron-root-path')
@@ -9,14 +8,15 @@ const getDebugInfo = require('../helpers/get-debug-info')
 const showDocs = require('../show-docs')
 
 const MENU_ITEM_IDS = require('../create-menu/menu.item.ids')
+const { changeMenuItemStatesById } = require('../create-menu/utils')
 
 const changelogPath = path.join(rootPath, 'CHANGELOG.md')
 
 const disableShowChangelogMenuItem = () => {
-  const menuItem = Menu.getApplicationMenu()
-    ?.getMenuItemById(MENU_ITEM_IDS.SHOW_CHANGE_LOG_MENU_ITEM) ?? {}
-
-  menuItem.enabled = false
+  changeMenuItemStatesById(
+    MENU_ITEM_IDS.SHOW_CHANGE_LOG_MENU_ITEM,
+    { enabled: false }
+  )
 }
 
 module.exports = async (params = {}) => {

src/create-menu/utils/change-menu-item-states-by-id.js

@@ -0,0 +1,53 @@
+'use strict'
+
+const { Menu, MenuItem } = require('electron')
+
+const MenuIpcChannelHandlers = require(
+  '../../window-creators/main-renderer-ipc-bridge/menu-ipc-channel-handlers'
+)
+const wins = require('../../window-creators/windows')
+const WINDOW_NAMES = require('../../window-creators/window.names')
+const isMainWinAvailable = require(
+  '../../helpers/is-main-win-available'
+)
+
+module.exports = (menuItemId, opts) => {
+  const menu = Menu.getApplicationMenu()
+  const args = Array.isArray(menuItemId)
+    ? menuItemId
+    : [{ menuItemId, opts }]
+
+  if (
+    !(menu instanceof Menu) ||
+    args.length === 0
+  ) {
+    return
+  }
+
+  for (const item of args) {
+    const id = item?.menuItemId
+    const props = {
+      ...item?.opts,
+      ...opts
+    }
+
+    if (!id) {
+      continue
+    }
+
+    const menuItem = id instanceof MenuItem
+      ? id
+      : menu.getMenuItemById(id)
+
+    for (const [name, val] of Object.entries(props)) {
+      menuItem[name] = val
+    }
+  }
+
+  if (!isMainWinAvailable()) {
+    return
+  }
+
+  MenuIpcChannelHandlers
+    .sendRerenderMenuEvent(wins[WINDOW_NAMES.MAIN_WINDOW])
+}

src/create-menu/utils/index.js

@@ -0,0 +1,9 @@
+'use strict'
+
+const changeMenuItemStatesById = require(
+  './change-menu-item-states-by-id'
+)
+
+module.exports = {
+  changeMenuItemStatesById
+}

src/error-manager/index.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const { app, Menu } = require('electron')
+const { app } = require('electron')
 const os = require('os')
 const cleanStack = require('clean-stack')
 const i18next = require('i18next')
@@ -20,6 +20,7 @@ const collectLogs = require('./collect-logs')
 const getDebugInfo = require('../helpers/get-debug-info')
 
 const MENU_ITEM_IDS = require('../create-menu/menu.item.ids')
+const { changeMenuItemStatesById } = require('../create-menu/utils')
 
 let _isLocked = false
 let _isIssueAutoManagerLocked = false
@@ -97,24 +98,22 @@ const _isLogSkipped = (log) => {
   )
 }
 
-const _getReportBugMenuItem = () => {
-  const menu = Menu.getApplicationMenu()
-
-  if (!menu) {
-    return {}
-  }
-
-  return menu.getMenuItemById(MENU_ITEM_IDS.REPORT_BUG_MENU_ITEM) || {}
-}
-
 const _lockIssueManager = () => {
   _isLocked = true
-  _getReportBugMenuItem().enabled = false
+
+  changeMenuItemStatesById(
+    MENU_ITEM_IDS.REPORT_BUG_MENU_ITEM,
+    { enabled: false }
+  )
 }
 
 const _unlockIssueManager = () => {
   _isLocked = false
-  _getReportBugMenuItem().enabled = true
+
+  changeMenuItemStatesById(
+    MENU_ITEM_IDS.REPORT_BUG_MENU_ITEM,
+    { enabled: true }
+  )
 }
 
 const manageNewGithubIssue = async (params) => {

src/helpers/is-main-win-available.js

@@ -1,9 +1,10 @@
 'use strict'
 
 const wins = require('../window-creators/windows')
+const WINDOW_NAMES = require('../window-creators/window.names')
 
 module.exports = (
-  win = wins?.mainWindow,
+  win = wins?.[WINDOW_NAMES.MAIN_WINDOW],
   opts = {}
 ) => {
   return (

src/window-creators/main-renderer-ipc-bridge/menu-ipc-channel-handlers.js

@@ -116,6 +116,10 @@ class MenuIpcChannelHandlers extends IpcChannelHandlers {
   static sendHideMenuEvent (win, args) {
     return this.sendToRenderer(this.sendHideMenuEvent, win, args)
   }
+
+  static sendRerenderMenuEvent (win, args) {
+    return this.sendToRenderer(this.sendRerenderMenuEvent, win, args)
+  }
 }
 
 module.exports = MenuIpcChannelHandlers

src/window-creators/main-renderer-ipc-bridge/preload.js

@@ -37,7 +37,8 @@ const MENU_INVOKE_METHOD_NAMES = {
   EXEC_MENU_CMD: 'execMenuCmd'
 }
 const MENU_EVENT_METHOD_NAMES = {
-  ON_HIDE_MENU_EVENT: 'onHideMenuEvent'
+  ON_HIDE_MENU_EVENT: 'onHideMenuEvent',
+  ON_RERENDER_MENU_EVENT: 'onRerenderMenuEvent'
 }
 const THEME_INVOKE_METHOD_NAMES = {
   SET_THEME: 'setTheme',