Implement BSIP47 account_update_votes_operation#2023
Open
oxarbitrage wants to merge 14 commits intobitshares:hardforkfrom
Open
Implement BSIP47 account_update_votes_operation#2023oxarbitrage wants to merge 14 commits intobitshares:hardforkfrom
oxarbitrage wants to merge 14 commits intobitshares:hardforkfrom
Conversation
abitmore
modified the milestones:
6.0.0 - Protocol Upgrade Release,
7.0.0 - Protocol Upgrade Release
abitmore
changed the title
abitmore
modified the milestones:
7.0.0 - Protocol Upgrade Release,
8.0.0 - Protocol Upgrade Release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/bitshares/bsips/blob/master/bsip-0047.md
Implemented following bsip specs but some things were changed. Most notably this implementation is not storing votes for each referendum categories in additional account object fields by filtering but keep using the same
options.votesset.This will save us from adding new code to
account_create_operationandaccount_update_operation.I don't think this is ready however good enough i hope for some review.