Resolve core #1116 by removing fc::[io]fstream#179
Open
pmconrad wants to merge 2 commits intobitshares:masterfrom
Open
Resolve core #1116 by removing fc::[io]fstream#179pmconrad wants to merge 2 commits intobitshares:masterfrom
pmconrad wants to merge 2 commits intobitshares:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue bitshares/bitshares-core#1116, also part of bitshares/bitshares-core#1584
Requires bitshares/bitshares-core#2047
This PR is a bit more dangerous than it seems. There are subtle differences in
fc's stream implementations, in particular wrt error handling.fcis non-standard and even inconsistent in that regard, which is one more reason to get rid of it IMO.