[PM-27816] Navigating back after error on Login With Device

[aj-rosado]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-27816

📔 Objective

On Login with Device screen, user is not being redirected to the login screen after an error and screen is not displaying fingerprint.
This aims to fix this by navigating the user back

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[claude]

Claude finished @aj-rosado's task —— View job

---

Code Review Complete

Overall Assessment: APPROVE

Clean bug fix that correctly addresses the navigation issue. The change adds a NavigateBack event when error dialogs are dismissed, ensuring users return to the login screen as expected. Implementation follows MVVM patterns and includes proper test coverage.

Findings

None - implementation is clean and correct.

PR Metadata Quality

💭 Title and Description: While functional, the PR title could be more specific about what changed:

Suggested improvement

Current: [PM-27816] Navigating back after error on Login With Device

Better: [PM-27816] Fix navigation by sending NavigateBack event on error dialog dismissal

Objective section could explain the root cause more clearly:

• What was missing: The handleErrorDialogDismissed() method wasn't sending a navigation event
• What was added: A single line calling sendEvent(LoginWithDeviceEvent.NavigateBack)

---

[github-actions]

Checkmarx One – Scan Summary & Details – 2989584b-8dab-4fab-9a3e-df5fff0c4f12

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.99%. Comparing base (21afa81) to head (5aef2a3).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6168      +/-   ##
==========================================
+ Coverage   84.97%   84.99%   +0.01%     
==========================================
  Files         735      723      -12     
  Lines       53087    52855     -232     
  Branches     7678     7676       -2     
==========================================
- Hits        45113    44926     -187     
+ Misses       5291     5246      -45     
  Partials     2683     2683              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.