[PM-18448] self-host: support other external database providers#227
Open
dionysius wants to merge 1 commit intobitwarden:mainfrom
Open
[PM-18448] self-host: support other external database providers#227dionysius wants to merge 1 commit intobitwarden:mainfrom
dionysius wants to merge 1 commit intobitwarden:mainfrom
Conversation
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
3c3f895 to
120cf36
Compare
120cf36 to
7c9699d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📔 Objective
Support other external database providers supported by bitwarden server: https://github.com/bitwarden/server/blob/main/src/Admin/Startup.cs#L50-L68
Optimally we would reorganise the values.yaml's
databaseproperty to make navigating it a bit cleaner. But the current implementation uses minimal changes and is backwards-compatible even ifdatabaseProvideris missing. There may be a way to simplify{{- if eq "sqlserver" (default "sqlserver" .Values.databaseProvider) }}.In my opinion supported provider sqlite doesn't make much sense in a helm managed kubernetes environment though it is technically almost possible with the current PR (missing volume setup) - hence not documented and the focus being external servers.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes