Skip to content

[BEEEP/RFC] Add noise IPC crypto provider#348

Draft
quexten wants to merge 1 commit intomainfrom
km/beeep/noise-ipc-cryptoprovider
Draft

[BEEEP/RFC] Add noise IPC crypto provider#348
quexten wants to merge 1 commit intomainfrom
km/beeep/noise-ipc-cryptoprovider

Conversation

@quexten
Copy link
Contributor

@quexten quexten commented Jul 11, 2025

🎟️ Tracking

📔 Objective

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025

Logo
Checkmarx One – Scan Summary & Detailsc719f5db-7eb2-4388-881f-807c7b5b74ae

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

❌ Patch coverage is 95.02370% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.38%. Comparing base (08a6bf3) to head (9dd7506).

Files with missing lines Patch % Lines
crates/bitwarden-ipc/src/wasm/ipc_client.rs 0.00% 11 Missing ⚠️
...itwarden-ipc/src/crypto_provider/noise/protocol.rs 96.59% 8 Missing ⚠️
...rypto_provider/noise/persistent_transport_state.rs 99.13% 1 Missing ⚠️
...bitwarden-wasm-internal/src/platform/repository.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
+ Coverage   80.02%   80.38%   +0.36%     
==========================================
  Files         312      315       +3     
  Lines       34516    34858     +342     
==========================================
+ Hits        27621    28021     +400     
+ Misses       6895     6837      -58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

🔍 SDK Breaking Change Detection Results

SDK Version: km/beeep/noise-ipc-cryptoprovider (9dd7506)
Completed: 2026-02-06 15:26:12 UTC
Total Time: 246s

Client Status Details
typescript ✅ No breaking changes detected TypeScript compilation passed with new SDK version - View Details

Breaking change detection completed. View SDK workflow

@quexten quexten force-pushed the km/beeep/noise-ipc-cryptoprovider branch from 213f62d to 9dd7506 Compare February 6, 2026 15:14
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant